Re: [RFC PATCH 2/6] bloom: prepare to discard incompatible Bloom filters
Taylor Blau <me@ttaylorr.com> writes:
Show 20 quoted lines
> diff --git a/bloom.h b/bloom.h
> index 330a140520..2b1c124bb5 100644
> --- a/bloom.h
> +++ b/bloom.h
> @@ -110,8 +110,24 @@ struct bloom_filter *get_or_compute_bloom_filter(struct repository *r,
> const struct bloom_filter_settings *settings,
> enum bloom_filter_computed *computed);
>
> -#define get_bloom_filter(r, c) get_or_compute_bloom_filter( \
> - (r), (c), 0, NULL, NULL)
> +/*
> + * Find the Bloom filter associated with the given commit "c".
> + *
> + * If any of the following are true
> + *
> + * - the repository does not have a commit-graph
> + * - it has a commit-graph, but reading the commit-graph is disabled
> + * - the given commit does not have a Bloom filter computed
> + * - there is a Bloom filter for commit "c", but it cannot be read because
> + * disabled
s/disabled/version incompatibility/, I think.
Show 8 quoted lines
> + *
> + * , then `get_bloom_filter()` will return NULL. Otherwise, the corresponding
> + * Bloom filter will be returned.
> + *
> + * For callers who wish to inspect Bloom filters with incompatible hash
> + * versions, use get_or_compute_bloom_filter().
> + */
> +struct bloom_filter *get_bloom_filter(struct repository *r, struct commit *c);