git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] repack: prevent geometry struct leak

From
Jeff King <peff@peff.net>
Date
Aug 10, 2023, 00:19 UTC
Message-ID
<20230810001921.GB795985@coredump.intra.peff.net>
In-Reply-To
<cover.1691613149.git.me@ttaylorr.com>
On Wed, Aug 09, 2023 at 04:32:36PM -0400, Taylor Blau wrote:
Show 6 quoted lines
> This short series combines a patch from Peff and a patch from me to
> prevent leaking the 'struct pack_geometry *' pointer from the repack
> code.
> 
> The first patch free()s the heap-allocated struct, and the second
> patch moves the variable to be allocated on the stack.

Thanks for cleaning up your patch. I think Junio has the first one in 'next' already as jk/repack-leakfix, but your patch 2 can go on top.

The result looks good to me. It's a little unusual that the "init" function expects the caller to have already initialized-to-zero and set the split_factor field, but I think that's OK for a struct that is limited to this one file.

-Peff
Previous: Taylor Blau
Message 7 of 7 in “repack: free geometry struct”
  1. repack: free geometry structJeff King, Aug 8, 2023
  2. Taylor BlauAug 8, 2023
  3. Jeff KingAug 8, 2023
  4. 0/2 repack: prevent geometry struct leakTaylor Blau, Aug 9, 2023
  5. 1/2 repack: free geometry structTaylor Blau, Aug 9, 2023
  6. 2/2 repack: move `pack_geometry` struct to the stackTaylor Blau, Aug 9, 2023
  7. Jeff KingAug 10, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.