git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] sha256/gcrypt: die on gcry_md_open failures

From
EWEric Wong <e@80x24.org>
Date
Jul 31, 2023, 12:08 UTC
Message-ID
<20230731120808.1230210-4-e@80x24.org>
In-Reply-To
<20230731120808.1230210-1-e@80x24.org>

`gcry_md_open' allocates memory and must (like all allocation functions) be checked for failure.

Signed-off-by: Eric Wong <e@80x24.org>
---
 sha256/gcrypt.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sha256/gcrypt.h b/sha256/gcrypt.h
index 1d06a778af..17a90f1052 100644
--- a/sha256/gcrypt.h
+++ b/sha256/gcrypt.h
@@ -9,7 +9,9 @@ typedef gcry_md_hd_t gcrypt_SHA256_CTX;
 
 static inline void gcrypt_SHA256_Init(gcrypt_SHA256_CTX *ctx)
 {
-	gcry_md_open(ctx, GCRY_MD_SHA256, 0);
+	gcry_error_t err = gcry_md_open(ctx, GCRY_MD_SHA256, 0);
+	if (err)
+		die("gcry_md_open: %s", gcry_strerror(err));
 }
 
 static inline void gcrypt_SHA256_Update(gcrypt_SHA256_CTX *ctx, const void *data, size_t len)
Previous: Eric WongNext: Junio C Hamano
Message 4 of 5 in “sha256/gcrypt fixes”
  1. 0/3 sha256/gcrypt fixesEric Wong, Jul 31, 2023
  2. 1/3 sha256/gcrypt: fix build with SANITIZE=leakEric Wong, Jul 31, 2023
  3. 2/3 sha256/gcrypt: fix memory leak with SHA-256 reposEric Wong, Jul 31, 2023
  4. 3/3 sha256/gcrypt: die on gcry_md_open failuresEric Wong, Jul 31, 2023
  5. Junio C HamanoJul 31, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.