git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 0/2] Add new "describe" atom

From
Kousik Sanagavarapu <five231003@gmail.com>
Date
Jul 25, 2023, 20:51 UTC
Message-ID
<20230725205924.40585-1-five231003@gmail.com>
In-Reply-To
<20230723162717.68123-1-five231003@gmail.com>

Hi, Thanks for the review on the previous version of this series. Here is a quick re-roll to address the minor changes that you left on the previous version (apart from the suggestions to PATCH 1/2).

Please queue this instead.
PATCH 1/2 - Left unchanged
PATCH 2/2 - Used the test helper function `test_must_fail` instead of
	    something like "! git foo" for making a command fail.
Kousik Sanagavarapu (2):
  ref-filter: add multiple-option parsing functions
  ref-filter: add new "describe" atom
 Documentation/git-for-each-ref.txt |  23 +++
 ref-filter.c                       | 230 +++++++++++++++++++++++++++++
 t/t6300-for-each-ref.sh            | 139 +++++++++++++++++
 3 files changed, 392 insertions(+)
Range-diff against v4:
1:  2914bd58ec = 1:  2914bd58ec ref-filter: add multiple-option parsing functions
2:  77a2a56520 ! 2:  8127f4399c ref-filter: add new "describe" atom
    @@ t/t6300-for-each-ref.sh: test_expect_success 'color.ui=always does not override
     +          cat >expect <<-\EOF &&
     +          fatal: unrecognized %(describe) argument: baz
     +          EOF
    -+          ! git for-each-ref --format="%(describe:baz)" \
    ++          test_must_fail git for-each-ref \
    ++                  --format="%(describe:baz)" \
     +                  refs/heads/master 2>actual &&
     +          test_cmp expect actual &&
     +
    @@ t/t6300-for-each-ref.sh: test_expect_success 'color.ui=always does not override
     +          cat >expect <<-\EOF &&
     +          fatal: unrecognized %(describe) argument: qux=1,abbrev=14
     +          EOF
    -+          ! git for-each-ref \
    ++          test_must_fail git for-each-ref \
     +                  --format="%(describe:tags,qux=1,abbrev=14)" \
     +                  ref/heads/master 2>actual &&
     +          test_cmp expect actual
-- 
2.41.0.396.g77a2a56520
Previous: Junio C HamanoNext: Kousik Sanagavarapu
Message 35 of 38 in “Add new "describe" atom”
  1. 0/2 Add new "describe" atomKousik Sanagavarapu, Jul 5, 2023
  2. 1/2 ref-filter: add new "describe" atomKousik Sanagavarapu, Jul 5, 2023
  3. Junio C HamanoJul 6, 2023
  4. Kousik SanagavarapuJul 9, 2023
  5. 2/2 t6300: run describe atom tests on a different repoKousik Sanagavarapu, Jul 5, 2023
  6. 0/3 Add new "describe" atomKousik Sanagavarapu, Jul 14, 2023
  7. 1/3 ref filter: add multiple-option parsing functionsKousik Sanagavarapu, Jul 14, 2023
  8. 2/3 ref-filter: add new "describe" atomKousik Sanagavarapu, Jul 14, 2023
  9. Junio C HamanoJul 14, 2023
  10. Kousik SanagavarapuJul 15, 2023
  11. Junio C HamanoJul 15, 2023
  12. 3/3 t6300: run describe atom tests on a different repoKousik Sanagavarapu, Jul 14, 2023
  13. 0/2 Add new "describe" atomKousik Sanagavarapu, Jul 19, 2023
  14. 1/2 ref-filter: add multiple-option parsing functionsKousik Sanagavarapu, Jul 19, 2023
  15. Junio C HamanoJul 19, 2023
  16. Junio C HamanoJul 20, 2023
  17. Kousik SanagavarapuJul 20, 2023
  18. Junio C HamanoJul 20, 2023
  19. Glen ChooJul 20, 2023
  20. Junio C HamanoJul 20, 2023
  21. Glen ChooJul 21, 2023
  22. 2/2 ref-filter: add new "describe" atomKousik Sanagavarapu, Jul 19, 2023
  23. Junio C HamanoJul 19, 2023
  24. Junio C HamanoJul 20, 2023
  25. Junio C HamanoJul 20, 2023
  26. Kousik SanagavarapuJul 21, 2023
  27. 0/2 Add new "describe" atomKousik Sanagavarapu, Jul 23, 2023
  28. 1/2 ref-filter: add multiple-option parsing functionsKousik Sanagavarapu, Jul 23, 2023
  29. Junio C HamanoJul 24, 2023
  30. Kousik SanagavarapuJul 24, 2023
  31. Junio C HamanoJul 24, 2023
  32. Junio C HamanoJul 25, 2023
  33. 2/2 ref-filter: add new "describe" atomKousik Sanagavarapu, Jul 23, 2023
  34. Junio C HamanoJul 24, 2023
  35. 0/2 Add new "describe" atomKousik Sanagavarapu, Jul 25, 2023
  36. 1/2 ref-filter: add multiple-option parsing functionsKousik Sanagavarapu, Jul 25, 2023
  37. 2/2 ref-filter: add new "describe" atomKousik Sanagavarapu, Jul 25, 2023
  38. Junio C HamanoJul 25, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.