git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] configure.ac: Don't overwrite NO_EXPAT option

From
AHAndreas Herrmann <aherrmann@suse.de>
Date
Jul 13, 2023, 07:45 UTC
Message-ID
<20230713074654.23957-1-aherrmann@suse.de>

Even if 'configure --with-expat=no' was run, expat support is used, because library detection overwrites it. Avoid this overwrite. (I think, configure should obey what the user has specified.)

Signed-off-by: Andreas Herrmann <aherrmann@suse.de>
---
 configure.ac | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/configure.ac b/configure.ac
index 38ff86678a..62cc8197f8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -581,6 +581,8 @@ fi
 # Define NO_EXPAT if you do not have expat installed.  git-http-push is
 # not built, and you cannot push using http:// and https:// transports.
 
+if test -z "$NO_EXPAT"; then
+
 GIT_STASH_FLAGS($EXPATDIR)
 
 AC_CHECK_LIB([expat], [XML_ParserCreate],
@@ -589,6 +591,8 @@ AC_CHECK_LIB([expat], [XML_ParserCreate],
 
 GIT_UNSTASH_FLAGS($EXPATDIR)
 
+fi
+
 GIT_CONF_SUBST([NO_EXPAT])
 
 #
-- 
2.41.0
Next: Junio C Hamano
Message 1 of 3 in “configure.ac: Don't overwrite NO_EXPAT option”
  1. configure.ac: Don't overwrite NO_EXPAT optionAndreas Herrmann, Jul 13, 2023
  2. Junio C HamanoJul 13, 2023
  3. Andreas HerrmannJul 14, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.