index.skipHash doesn't work with split index, was Re: Bug Report

From: Jeff King <peff@peff.net>
Date: Jun 29, 2023, 08:38 UTC
Message-ID: <20230629083859.GA585934@coredump.intra.peff.net>
In-Reply-To: <CAO=RawtAvOna1xrBNY+T-fo4UQe-ipC6OvFODvOSdu4wUML3Ng@mail.gmail.com>

On Tue, Jun 27, 2023 at 05:02:30PM +0100, Tiago d'Almeida wrote:

> Attached to this email follow the `git bugreport` and global `config`
> files, and the git_bug repo.

Thanks for providing your config; it was very important to reproducing. The bug comes from the combination of "core.splitIndex" and "index.skipHash" (the latter is triggered in your config by "feature.manyFiles").

Here's a quick reproduction:

  git init repo
  cd repo
  touch file
  git -c core.splitIndex=true -c index.skipHash=true add file

That should add "file" to the index but doesn't. Removing either the splitIndex option or the skipHash option makes it work. I didn't dig further than that.

Adding the author of skipHash to the cc.

-Peff