git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] ci: drop linux-clang job

From
Jeff King <peff@peff.net>
Date
Jun 1, 2023, 18:10 UTC
Message-ID
<20230601181040.GC4167886@coredump.intra.peff.net>
In-Reply-To
<20230601180220.GA4167745@coredump.intra.peff.net>

Since the linux-asan-ubsan job runs using clang under Linux, there is not much point in running a separate clang job. Any errors that a normal clang compile-and-test cycle would find are likely to be a subset of what the sanitizer job will find. Since this job takes ~14 minutes to run in CI, this shaves off some of our CPU load (though it does not affect end-to-end runtime, since it's typically run in parallel and is not the longest job).

Technically this provides us with slightly less signal for a given run, since you won't immediately know if a failure in the sanitizer job is from using clang or from the sanitizers themselves. But it's generally obvious from the logs, and anyway your next step would be to fix the probvlem and re-run CI, since we expect all of these jobs to pass normally.

Signed-off-by: Jeff King <peff@peff.net>
---
Obviously not necessary, but just seemed like another easy way to trim
our resource usage. Really, the same logic could apply before my series
to the linux-gcc job, which is similarly redundant.
 .github/workflows/main.yml | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 2114303b7d..079645b776 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -246,9 +246,6 @@ jobs:
       fail-fast: false
       matrix:
         vector:
-          - jobname: linux-clang
-            cc: clang
-            pool: ubuntu-latest
           - jobname: linux-sha256
             cc: clang
             pool: ubuntu-latest
-- 
2.41.0.346.g8d12207a4f
Previous: Jeff KingNext: Junio C Hamano
Message 4 of 5 in “ci sanitizer cleanups and performance improvements”
  1. 0/3 ci sanitizer cleanups and performance improvementsJeff King, Jun 1, 2023
  2. 1/3 ci: use clang for ASan/UBSan checksJeff King, Jun 1, 2023
  3. 2/3 ci: run ASan/UBSan in a single jobJeff King, Jun 1, 2023
  4. 3/3 ci: drop linux-clang jobJeff King, Jun 1, 2023
  5. Junio C HamanoJun 3, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.