[PATCH 1/2] format-patch: free rev.message_id when exiting
- From
Jeff King <peff@peff.net>
- Date
- May 19, 2023, 00:03 UTC
- Message-ID
- <20230519000325.GA1975194@coredump.intra.peff.net>
- In-Reply-To
- <20230519000239.GA1975039@coredump.intra.peff.net>
We may allocate a message-id string via gen_message_id(), but we never free it, causing a small leak. This can be demonstrated by running t9001 with a leak-checking build. The offending test is the one touched by 3ece9bf0f9 (send-email: clear the $message_id after validation, 2023-05-17), but the leak is much older than that. The test was simply unlucky enough to trigger the leaking code path for the first time.
We can fix this by freeing the string at the end of the function. We can also re-mark the test script as leak-free, effectively reverting 20bd08aefb (t9001: mark the script as no longer leak checker clean, 2023-05-17).
Signed-off-by: Jeff King <peff@peff.net> --- builtin/log.c | 1 + t/t9001-send-email.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/builtin/log.c b/builtin/log.c index 7d19578963..ab74760386 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -2415,6 +2415,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix) strbuf_release(&rdiff_title); strbuf_release(&sprefix); free(to_free); + free(rev.message_id); if (rev.ref_message_ids) string_list_clear(rev.ref_message_ids, 0); free(rev.ref_message_ids); diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 2051103226..8d49eff91a 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -4,7 +4,7 @@ test_description='git send-email' GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME -# no longer TEST_PASSES_SANITIZE_LEAK=true - format-patch --thread leaks +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh # May be altered later in the test
-- 2.41.0.rc0.359.g22664e20e7