git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 05/15] version-gen: simplify update check

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 24, 2023, 16:50 UTC
Message-ID
<20230424165041.25180-6-felipe.contreras@gmail.com>
In-Reply-To
<20230424165041.25180-1-felipe.contreras@gmail.com>

We don't need to extract the version when we can compare the whole contents.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 GIT-VERSION-GEN | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index c0f6bb242f..34f561752b 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -35,11 +35,5 @@ fi
 
 VN=${VN#v}
 
-if test -r $GVF
-then
-	VC=$(sed -e 's/^GIT_VERSION = //' <$GVF)
-else
-	VC='unset'
-fi
-test "$VN" = "$VC" && exit
+test -r $GVF && test "GIT_VERSION = $VN" = "$(cat $GVF)" && exit
 echo "GIT_VERSION = $VN" | tee $GVF >&2
-- 
2.40.0+fc1
Previous: Felipe ContrerasNext: Felipe Contreras
Message 6 of 16 in “version-gen: complete revamp/rewrite”
  1. 00/15 version-gen: complete revamp/rewriteFelipe Contreras, Apr 24, 2023
  2. 04/15 version-gen: simplify v prefix removalFelipe Contreras, Apr 24, 2023
  3. 01/15 version-gen: reorganizeFelipe Contreras, Apr 24, 2023
  4. 03/15 version-gen: refactor default versionFelipe Contreras, Apr 24, 2023
  5. 02/15 version-gen: trivial cleanupFelipe Contreras, Apr 24, 2023
  6. 05/15 version-gen: simplify update checkFelipe Contreras, Apr 24, 2023
  7. 06/15 version-gen: simplify `git describe` checksFelipe Contreras, Apr 24, 2023
  8. 07/15 version-gen: simplify dirty checkFelipe Contreras, Apr 24, 2023
  9. 08/15 version-gen: move describe fix into functionFelipe Contreras, Apr 24, 2023
  10. 09/15 version-gen: describe and sed in one goFelipe Contreras, Apr 24, 2023
  11. 10/15 version-gen: refactor describe functionFelipe Contreras, Apr 24, 2023
  12. 11/15 version-gen: do v fix only when necessaryFelipe Contreras, Apr 24, 2023
  13. 12/15 version-gen: move v fix into sedFelipe Contreras, Apr 24, 2023
  14. 13/15 version-gen: refactor main functionalityFelipe Contreras, Apr 24, 2023
  15. 14/15 version-gen: refactor GIT_VERSION stringFelipe Contreras, Apr 24, 2023
  16. 15/15 version-gen: get rid of GVF variableFelipe Contreras, Apr 24, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.