Re: Infinite loop + memory leak in annotate_refs_with_symref_info

From: Jeff King <peff@peff.net>
Date: Apr 11, 2023, 21:06 UTC
Message-ID: <20230411210633.GA626331@coredump.intra.peff.net>
In-Reply-To: <39035D34-8548-44B0-BBBB-5C36B3876C4A@lophus.org>

On Tue, Apr 11, 2023 at 10:53:59PM +0300, Jonas Haag wrote:

> There is an infinite loop with an accompanying memory leak in
> annotate_refs_with_symref_info that was introduced in Git 2.28 (I
> think in commit 2c6a403: “connect: add function to parse multiple v1
> capability values”).

Have you tried to reproduce with a more recent version of Git? This sounds a lot like the bug fixed in 44d2aec6e8 (connect: also update offset for features without values, 2021-09-26), which is in v2.33.1.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.