Re: [PATCH] date: remove approxidate_relative()

From: Jeff King <peff@peff.net>
Date: Apr 11, 2023, 09:25 UTC
Message-ID: <20230411092502.GA398350@coredump.intra.peff.net>
In-Reply-To: <b17e05d5-deda-527f-1587-9f1cd7046a0b@web.de>

On Mon, Apr 10, 2023 at 10:52:01PM +0200, René Scharfe wrote:

Show 14 quoted lines

> Am 10.04.23 um 22:25 schrieb Jeff King:
> >
> > I'm not sure of the least-confusing way to address a single hunk, though
> > (by line number is one option, by hunk-number within the patch is
> > another). I suspect the best workflow for a user would be to
> > interactively say "show me more context for this hunk". Some viewers
> > have support for that (e.g., GitHub's web view of a diff). But handling
> > that for a one-shot CLI program is tricky, not to mention then feeding
> > it back to format-patch to generate the output you want to send. :)
> 
> So basically you propose a format-patch --interactive mode that shows
> each hunk and allows extending its context.  This could work.  For hunks
> that span multiple screens it might be a bit iffy -- or perhaps not, if
> the scrollback buffer of the terminal or console is big enough.

Well, less proposing and more thinking out loud. :)

One thing that I think would make it awkward is that some people (well, me at least) tend to show diffs repeatedly. So I might look at a diff several times, and then even run format-patch multiple times as part of my workflow of sending it. Interactively expanding the diff each time, and then losing that result, would be annoying.

So an interactive tool that somehow output "oh, and here are some parameters you can feed back to get the same view" would be my ideal.

-Peff