[PATCH v7 24/49] completion: zsh: fix extra space on foo=
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Apr 1, 2023, 08:46 UTC
- Message-ID
- <20230401084626.304356-25-felipe.contreras@gmail.com>
- In-Reply-To
- <20230401084626.304356-1-felipe.contreras@gmail.com>
Upstream commit e1e00089da fixed the issue for Bash, but not for Zsh.
When we are typing configurations an = at the end signifies we still want to type the value.
Can be tested with:
git -c log.d<tab>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> --- contrib/completion/git-completion.zsh | 2 +- t/t9904-completion-zsh.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh index a7a5efbd13..038ab30869 100644 --- a/contrib/completion/git-completion.zsh +++ b/contrib/completion/git-completion.zsh @@ -87,7 +87,7 @@ __gitcomp () fi c="$c${4-}" case $c in - --*=|*.) ;; + *=|*.) ;; *) c="$c " ;; esac array+=("$c") diff --git a/t/t9904-completion-zsh.sh b/t/t9904-completion-zsh.sh index 1b18bf5363..4355552434 100755 --- a/t/t9904-completion-zsh.sh +++ b/t/t9904-completion-zsh.sh @@ -1097,7 +1097,7 @@ test_expect_success 'git -c - section' ' EOF ' -test_expect_failure 'git -c - variable name' ' +test_expect_success 'git -c - variable name' ' test_completion "git -c log.d" <<-\EOF log.date=Z log.decorate=Z @@ -1119,7 +1119,7 @@ test_expect_success 'git clone --config= - section' ' EOF ' -test_expect_failure 'git clone --config= - variable name' ' +test_expect_success 'git clone --config= - variable name' ' test_completion "git clone --config=log.d" <<-\EOF log.date=Z log.decorate=Z
-- 2.33.0