git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] t2107: fix mention of the_index.cache_changed

From
Andrei Rybak <rybak.a.v@gmail.com>
Date
Mar 31, 2023, 14:36 UTC
Message-ID
<20230331143604.82040-2-rybak.a.v@gmail.com>
In-Reply-To
<20230331143604.82040-1-rybak.a.v@gmail.com>

Commit [1] added a test to t2107-update-index-basic.sh with a comment that mentions macro "active_cache_changed". Later in [2], the macro was removed and its usage in function cmd_update_index in file builtin/update-index.c was replaced with "the_index.cache_changed".

Fix the outdated comment in file t2107-update-index-basic.sh.
[1] fa137f67a4 (lockfile.c: store absolute path, 2014-11-02)
[2] dc594180d9 (cocci & cache.h: apply variable section of "pending"
    index-compatibility, 2022-11-19)
Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
---
 t/t2107-update-index-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Found this by while investigating the root cause for the first patch in this series.

diff --git a/t/t2107-update-index-basic.sh b/t/t2107-update-index-basic.sh
index 07e6de84e6..89b285fa3a 100755
--- a/t/t2107-update-index-basic.sh
+++ b/t/t2107-update-index-basic.sh
@@ -83,7 +83,7 @@ test_expect_success '.lock files cleaned up' '
 	cd repo &&
 	git config core.worktree ../../worktree &&
 	# --refresh triggers late setup_work_tree,
-	# active_cache_changed is zero, rollback_lock_file fails
+	# the_index.cache_changed is zero, rollback_lock_file fails
 	git update-index --refresh --verbose >out &&
 	test_must_be_empty out &&
 	! test -f .git/index.lock
-- 
2.40.0
Previous: Andrei Rybak
Message 2 of 2 in “t3060: fix mention of function prune_index”
  1. 1/2 t3060: fix mention of function prune_indexAndrei Rybak, Mar 31, 2023
  2. 2/2 t2107: fix mention of the_index.cache_changedAndrei Rybak, Mar 31, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.