git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/7] unused argc/argv/prefix parameters

From
Jeff King <peff@peff.net>
Date
Mar 28, 2023, 20:52 UTC
Message-ID
<20230328205253.GA1753925@coredump.intra.peff.net>

More from my -Wunused-parameter silencing. The first one actually fixes a bug. The second is a cleanup, and the rest are just UNUSED annotations (but grouped into similar cases).

  [1/7]: fast-import: fix file access when run from subdir
  [2/7]: builtins: always pass prefix to parse_options()
  [3/7]: builtins: annotate always-empty prefix parameters
  [4/7]: builtins: mark unused prefix parameters
  [5/7]: mark "argv" as unused when we check argc
  [6/7]: t/helper: mark unused argv/argc arguments
  [7/7]: parse-options: drop parse_opt_unknown_cb()
 builtin.h                            | 10 ++++++++++
 builtin/check-ref-format.c           |  2 ++
 builtin/credential.c                 |  2 +-
 builtin/diff.c                       |  6 +++---
 builtin/fast-import.c                | 10 ++++++++--
 builtin/fetch-pack.c                 |  2 +-
 builtin/fsmonitor--daemon.c          |  2 +-
 builtin/get-tar-commit-id.c          |  4 +++-
 builtin/mailsplit.c                  |  2 ++
 builtin/merge-index.c                |  2 +-
 builtin/merge-ours.c                 |  2 +-
 builtin/merge-recursive.c            |  2 +-
 builtin/mktag.c                      |  2 +-
 builtin/pack-redundant.c             |  2 +-
 builtin/remote-ext.c                 |  2 ++
 builtin/remote-fd.c                  |  2 ++
 builtin/revert.c                     |  9 +++++----
 builtin/stash.c                      |  2 +-
 builtin/submodule--helper.c          |  2 +-
 builtin/unpack-file.c                |  2 +-
 builtin/unpack-objects.c             |  2 +-
 builtin/upload-archive.c             |  2 ++
 builtin/var.c                        |  2 +-
 parse-options-cb.c                   | 15 --------------
 parse-options.h                      |  3 ---
 scalar.c                             |  2 +-
 t/helper/test-ctype.c                |  2 +-
 t/helper/test-date.c                 |  2 +-
 t/helper/test-drop-caches.c          |  2 +-
 t/helper/test-dump-cache-tree.c      |  2 +-
 t/helper/test-dump-fsmonitor.c       |  2 +-
 t/helper/test-dump-split-index.c     |  2 +-
 t/helper/test-dump-untracked-cache.c |  2 +-
 t/helper/test-example-decorate.c     |  2 +-
 t/helper/test-fsmonitor-client.c     |  2 +-
 t/helper/test-hexdump.c              |  2 +-
 t/helper/test-index-version.c        |  2 +-
 t/helper/test-match-trees.c          |  2 +-
 t/helper/test-oid-array.c            |  2 +-
 t/helper/test-oidmap.c               |  2 +-
 t/helper/test-oidtree.c              |  4 ++--
 t/helper/test-online-cpus.c          |  2 +-
 t/helper/test-parse-options.c        |  4 ++--
 t/helper/test-prio-queue.c           |  2 +-
 t/helper/test-read-graph.c           |  2 +-
 t/helper/test-ref-store.c            |  5 +++--
 t/helper/test-scrap-cache-tree.c     |  2 +-
 t/helper/test-sigchain.c             |  2 +-
 t/helper/test-strcmp-offset.c        |  2 +-
 t/helper/test-submodule-config.c     |  2 +-
 t/helper/test-submodule.c            |  2 +-
 t/helper/test-trace2.c               |  6 +++---
 t/helper/test-xml-encode.c           |  2 +-
 t/t9304-fast-import-marks.sh         | 29 ++++++++++++++++++++++++++++
 54 files changed, 115 insertions(+), 74 deletions(-)
Next: Jeff King
Message 1 of 10 in “unused argc/argv/prefix parameters”
  1. 0/7 unused argc/argv/prefix parametersJeff King, Mar 28, 2023
  2. 1/7 fast-import: fix file access when run from subdirJeff King, Mar 28, 2023
  3. 2/7 builtins: always pass prefix to parse_options()Jeff King, Mar 28, 2023
  4. 3/7 builtins: annotate always-empty prefix parametersJeff King, Mar 28, 2023
  5. 4/7 builtins: mark unused prefix parametersJeff King, Mar 28, 2023
  6. 5/7 mark "argv" as unused when we check argcJeff King, Mar 28, 2023
  7. 6/7 t/helper: mark unused argv/argc argumentsJeff King, Mar 28, 2023
  8. 7/7 parse-options: drop parse_opt_unknown_cb()Jeff King, Mar 28, 2023
  9. Derrick StoleeMar 29, 2023
  10. Junio C HamanoMar 29, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.