Re: [PATCH] t3070: make chain lint tester happy

From: Jeff King <peff@peff.net>
Date: Mar 25, 2023, 08:36 UTC
Message-ID: <20230325083658.GA3738217@coredump.intra.peff.net>
In-Reply-To: <CAPig+cSdBTeeWX-UAoUXzt1b+nC=xRgtPTHgtg+kSBAbeCKedg@mail.gmail.com>

On Sat, Mar 25, 2023 at 04:06:39AM -0400, Eric Sunshine wrote:

Show 12 quoted lines

> On Sat, Mar 25, 2023 at 3:58 AM Jeff King <peff@peff.net> wrote:
> > On Sat, Mar 25, 2023 at 02:54:45AM -0400, Eric Sunshine wrote:
> > > I am unable to reproduce any linting errors when running this script
> > > through chainlint, which is why I was more than a little confused by
> > > this patch when I read it, and I was just about to ask for more
> > > information, such as the actual error message.
> >
> > It's not your chain-lint script, but rather the builtin one that sticks
> > "(exit 117) &&" in front of the snippet and evals it. So it creates the
> > exact "foo && bar &" situation by prepending a line to the snippet.
> 
> Thanks for clarifying that. I failed to infer that from the commit message.

To be fair, I didn't figure it out from the commit either. It's just that running it stand-alone was the first thing I happened to try. ;)

> Yes, I can reproduce it now. My mistake was that I tested 'seen'
> rather than 1f2e05f0b79, not realizing that Junio had already applied
> Michael's patch. (I meant to check if it had been applied, but forgot
> to do so.)

Oof. I got lucky twice, then, because I did run "seen" but I hadn't fetched recently enough.

-Peff