git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 7/7] t1507: assert output of rev-parse

From
Andrei Rybak <rybak.a.v@gmail.com>
Date
Mar 24, 2023, 20:54 UTC
Message-ID
<20230324205434.93754-8-rybak.a.v@gmail.com>
In-Reply-To
<20230324205434.93754-1-rybak.a.v@gmail.com>

Tests in t1507-rev-parse-upstream.sh compare files "expect" and "actual" to assert the output of "git rev-parse", "git show", and "git log". However, two of the tests '@{reflog}-parsing does not look beyond colon' and '@{upstream}-parsing does not look beyond colon' don't inspect the contents of the created files.

Assert output of "git rev-parse" in tests in t1507-rev-parse-upstream.sh to improve test coverage.

Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
---
 t/t1507-rev-parse-upstream.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t1507-rev-parse-upstream.sh b/t/t1507-rev-parse-upstream.sh
index c34714ffe3..4458820168 100755
--- a/t/t1507-rev-parse-upstream.sh
+++ b/t/t1507-rev-parse-upstream.sh
@@ -258,7 +258,8 @@ test_expect_success '@{reflog}-parsing does not look beyond colon' '
 	git add @{yesterday} &&
 	git commit -m "funny reflog file" &&
 	git hash-object @{yesterday} >expect &&
-	git rev-parse HEAD:@{yesterday} >actual
+	git rev-parse HEAD:@{yesterday} >actual &&
+	test_cmp expect actual
 '
 
 test_expect_success '@{upstream}-parsing does not look beyond colon' '
@@ -266,7 +267,8 @@ test_expect_success '@{upstream}-parsing does not look beyond colon' '
 	git add @{upstream} &&
 	git commit -m "funny upstream file" &&
 	git hash-object @{upstream} >expect &&
-	git rev-parse HEAD:@{upstream} >actual
+	git rev-parse HEAD:@{upstream} >actual &&
+	test_cmp expect actual
 '
 
 test_done
-- 
2.40.0
Previous: Andrei RybakNext: Junio C Hamano
Message 32 of 33 in “t: fix unused files, part 1”
  1. 0/7 t: fix unused files, part 1Andrei Rybak, Mar 12, 2023
  2. 1/7 t1005: assert output of ls-filesAndrei Rybak, Mar 12, 2023
  3. Michael J GruberMar 14, 2023
  4. Andrei RybakMar 18, 2023
  5. 1/1 t1507: assert output of rev-parseAndrei Rybak, Mar 12, 2023
  6. Andrei RybakMar 12, 2023
  7. 2/7 t1006: assert error output of cat-fileAndrei Rybak, Mar 12, 2023
  8. 3/7 t1010: assert empty output of mktreeAndrei Rybak, Mar 12, 2023
  9. Junio C HamanoMar 13, 2023
  10. 4/7 t1302: don't create unused fileAndrei Rybak, Mar 12, 2023
  11. 5/7 t1400: assert output of update-refAndrei Rybak, Mar 12, 2023
  12. 6/7 t1404: don't create unused fileAndrei Rybak, Mar 12, 2023
  13. Junio C HamanoMar 13, 2023
  14. 7/7 t1507: assert output of rev-parseAndrei Rybak, Mar 12, 2023
  15. Junio C HamanoMar 13, 2023
  16. Andrei RybakMar 14, 2023
  17. 0/7 t: fix unused files, part 1Andrei Rybak, Mar 18, 2023
  18. 1/7 t1005: assert output of ls-filesAndrei Rybak, Mar 18, 2023
  19. 2/7 t1006: assert error output of cat-fileAndrei Rybak, Mar 18, 2023
  20. 3/7 t1010: don't create unused filesAndrei Rybak, Mar 18, 2023
  21. 4/7 t1302: don't create unused fileAndrei Rybak, Mar 18, 2023
  22. 5/7 t1400: assert output of update-refAndrei Rybak, Mar 18, 2023
  23. 7/7 t1507: assert output of rev-parseAndrei Rybak, Mar 18, 2023
  24. 6/7 t1404: don't create unused fileAndrei Rybak, Mar 18, 2023
  25. 0/7 t: fix unused files, part 1Andrei Rybak, Mar 24, 2023
  26. 1/7 t1005: assert output of ls-filesAndrei Rybak, Mar 24, 2023
  27. 2/7 t1006: assert error output of cat-fileAndrei Rybak, Mar 24, 2023
  28. 3/7 t1010: don't create unused filesAndrei Rybak, Mar 24, 2023
  29. 5/7 t1400: assert output of update-refAndrei Rybak, Mar 24, 2023
  30. 4/7 t1302: don't create unused fileAndrei Rybak, Mar 24, 2023
  31. 6/7 t1404: don't create unused fileAndrei Rybak, Mar 24, 2023
  32. 7/7 t1507: assert output of rev-parseAndrei Rybak, Mar 24, 2023
  33. Junio C HamanoMar 28, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.