[PATCH 1/6] fast-export: drop const when storing anonymized values
- From
Jeff King <peff@peff.net>
- Date
- Mar 22, 2023, 17:37 UTC
- Message-ID
- <20230322173717.GA5795@coredump.intra.peff.net>
- In-Reply-To
- <20230322173636.GA5643@coredump.intra.peff.net>
We store anonymized values as pointers to "const char *", since they are conceptually const to callers who use them. But they are actually allocated strings whose memory is owned by the struct.
The ownership mismatch hasn't been a big deal since we never free() them (they are held until the program ends), but let's switch them to "char *" in preparation for changing that.
Since most code only accesses them via anonymize_str(), it can continue to narrow them to "const char *" in its return value.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/fast-export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/fast-export.c b/builtin/fast-export.c index 78493c6d2bf..f422819c82a 100644 --- a/builtin/fast-export.c +++ b/builtin/fast-export.c @@ -110,7 +110,7 @@ static struct decoration idnums; static uint32_t last_idnum; struct anonymized_entry { struct hashmap_entry hash; - const char *anon; + char *anon; const char orig[FLEX_ARRAY]; };
-- 2.40.0.595.g9b96b494d8c