Re: [PATCH] doc: remove GNU troff workaround

From: Jeff King <peff@peff.net>
Date: Mar 21, 2023, 17:32 UTC
Message-ID: <20230321173206.GC3119834@coredump.intra.peff.net>
In-Reply-To: <20230320190047.79836-1-felipe.contreras@gmail.com>

On Mon, Mar 20, 2023 at 01:00:47PM -0600, Felipe Contreras wrote:

Show 9 quoted lines

> Unfortunately by that point many workarounds already existed. In the
> case of git, GNU_ROFF was introduced, and in the case of Arch Linux
> a mapping from \' to ' was added to groff's man.local. Other
> distributions might have done the same, or similar workarounds.
> 
> Since 2010 there is no need for this workaround, which is fixed
> elsewhere, not just in docbook, but other layers as well.
> 
> Let's remove it.

Thanks, it's nice to get rid of old cruft like this when it's no longer useful.

One thing I wondered about, though: even if docbook fixed it in 2010, the workaround is still useful for a while, as it takes time for newly released versions to be available everywhere.

I'd think 13 years is probably long enough, but I was curious about the versions. You referenced the fix here:

> [6] https://github.com/docbook/xslt10-stylesheets/commit/fb553434265906ed81edc6d5f533d0b08d200046

but the earliest tag in that repository that contains that commit is 1.79.1 from 2016. However, it seems like that repo is oddly missing older tags. You mentioned 1.76 earlier, and the changelog for the Debian package of docbook-xsl mentions the 1.76 release fixing it in 2010.

So assuming the fix really was released in 2010, even long-running distros like CentOS probably would have picked it up within a few years, and our workaround should definitely be obsolete by now.

-Peff