git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] perf: grep: fix prereqs

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Mar 12, 2023, 20:08 UTC
Message-ID
<20230312200856.323688-3-felipe.contreras@gmail.com>
In-Reply-To
<20230312200856.323688-1-felipe.contreras@gmail.com>

Since 5dccd9155f (t/perf: add iteration setup mechanism to perf-lib, 2022-04-04) they are in a --prereq option.

Cc: Neeraj Singh <neerajsi@microsoft.com>
Cc: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/perf/p7821-grep-engines-fixed.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/perf/p7821-grep-engines-fixed.sh b/t/perf/p7821-grep-engines-fixed.sh
index 61e41b82cf..0d75240dae 100755
--- a/t/perf/p7821-grep-engines-fixed.sh
+++ b/t/perf/p7821-grep-engines-fixed.sh
@@ -33,13 +33,13 @@ do
 		fi
 		if ! test_have_prereq PERF_GREP_ENGINES_THREADS
 		then
-			test_perf $prereq "$engine grep$GIT_PERF_7821_GREP_OPTS $pattern" "
+			test_perf "$engine grep$GIT_PERF_7821_GREP_OPTS $pattern" --prereq "$prereq" "
 				git -c grep.patternType=$engine grep$GIT_PERF_7821_GREP_OPTS $pattern >'out.$engine' || :
 			"
 		else
 			for threads in $GIT_PERF_GREP_THREADS
 			do
-				test_perf PTHREADS,$prereq "$engine grep$GIT_PERF_7821_GREP_OPTS $pattern with $threads threads" "
+				test_perf "$engine grep$GIT_PERF_7821_GREP_OPTS $pattern with $threads threads" --prereq "$prereq" "
 					git -c grep.patternType=$engine -c grep.threads=$threads grep$GIT_PERF_7821_GREP_OPTS $pattern >'out.$engine.$threads' || :
 				"
 			done
-- 
2.39.2.13.g1fb56cf030
Previous: Felipe ContrerasNext: Felipe Contreras
Message 3 of 6 in “perf: fixes and cleanups”
  1. 0/5 perf: fixes and cleanupsFelipe Contreras, Mar 12, 2023
  2. 1/5 perf: sparse: remove grep --sparse optionFelipe Contreras, Mar 12, 2023
  3. 2/5 perf: grep: fix prereqsFelipe Contreras, Mar 12, 2023
  4. 3/5 perf: grep: don't check PRCE twiceFelipe Contreras, Mar 12, 2023
  5. 5/5 perf: aggregate: check if subtest existsFelipe Contreras, Mar 12, 2023
  6. 4/5 perf: grep: avoid unused prereqFelipe Contreras, Mar 12, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.