git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC][PATCH] t/t5000-tar-tree: add helper function

From
Kostya Farber <kostya.farber@gmail.com>
Date
Feb 2, 2023, 20:25 UTC
Message-ID
<20230202202557.19297-1-kostya.farber@gmail.com>

Add the helper function test_file_path_exists to the interpret pax header test. This change makes it clearer as to what the test is trying to check, in this case whether a file path exists.

Signed-off-by: Kostya Farber <kostya.farber@gmail.com>
---
Hello all. I'd like to introduce myself. My name is 
Kostya, I am new to the git open source community.

I am a data engineer by trade, but have recently gotten into (and am really enjoying) the open source world. My main contributions have been in the scientific python space (https://github.com/kostyafarber).

I have read MyFirstContribution, documentation in t/README and the general GSoC page. I have really started to enjoy low-level programming and have been going through The C Programming Language (Second Edition) and the Linux Programming Interface.

I am planning to submit a proposal for GSoC (hopefully) and want to try help out and contribute to a tool I've been using for a long time and have love for.

Keen to speak to you all soon. 
 t/t5000-tar-tree.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
index d473048138..19d5bd0c04 100755
--- a/t/t5000-tar-tree.sh
+++ b/t/t5000-tar-tree.sh
@@ -73,7 +73,7 @@ check_tar() {
 			for header in *.paxheader
 			do
 				data=${header%.paxheader}.data &&
-				if test -h $data || test -e $data
+				if test -h $data || test_file_path_exists $data
 				then
 					path=$(get_pax_header $header path) &&
 					if test -n "$path"
-- 
2.39.0
Next: Junio C Hamano
Message 1 of 8 in “t/t5000-tar-tree: add helper function”
  1. Kostya FarberFeb 2, 2023
  2. Junio C HamanoFeb 2, 2023
  3. Eric SunshineFeb 2, 2023
  4. Eric SunshineFeb 2, 2023
  5. Kostya FarberFeb 4, 2023
  6. Eric SunshineFeb 5, 2023
  7. Kostya FarberFeb 4, 2023
  8. Kostya FarberFeb 4, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.