git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/6] t3104: remove shift code in 'test_ls_tree_format'

From
Teng Long <dyroneteng@gmail.com>
Date
Jan 12, 2023, 09:11 UTC
Message-ID
<20230112091135.20050-7-tenglong.tl@alibaba-inc.com>
In-Reply-To
<20230112091135.20050-1-tenglong.tl@alibaba-inc.com>
From: Teng Long <dyroneteng@gmail.com>

In t3104-ls-tree-format.sh, There is a legacy 'shift 2' code and the relevant code block no longer depends on it anymore, so let's remove it for a small cleanup.

Signed-off-by: Teng Long <dyroneteng@gmail.com>
---
 t/t3104-ls-tree-format.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/t/t3104-ls-tree-format.sh b/t/t3104-ls-tree-format.sh
index 383896667b6..74053978f49 100755
--- a/t/t3104-ls-tree-format.sh
+++ b/t/t3104-ls-tree-format.sh
@@ -20,7 +20,6 @@ test_ls_tree_format () {
 	format=$1 &&
 	opts=$2 &&
 	fmtopts=$3 &&
-	shift 2 &&
 
 	test_expect_success "ls-tree '--format=<$format>' is like options '$opts $fmtopts'" '
 		git ls-tree $opts -r HEAD >expect &&
-- 
2.39.0.98.g174eaa53973.dirty
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 8 of 10 in “ls-tree.c: clean-up works”
  1. 0/6 ls-tree.c: clean-up worksTeng Long, Jan 12, 2023
  2. 1/6 ls-tree: don't use "show_tree_data" for "fast" callbacksTeng Long, Jan 12, 2023
  3. 2/6 ls-tree: use a "struct options"Teng Long, Jan 12, 2023
  4. 3/6 ls-tree: fold "show_tree_data" into "cb" structTeng Long, Jan 12, 2023
  5. 4/6 ls-tree: make "line_termination" less genericTeng Long, Jan 12, 2023
  6. 5/6 ls-tree: cleanup the redundant SPACETeng Long, Jan 12, 2023
  7. Ævar Arnfjörð BjarmasonJan 12, 2023
  8. 6/6 t3104: remove shift code in 'test_ls_tree_format'Teng Long, Jan 12, 2023
  9. Ævar Arnfjörð BjarmasonJan 12, 2023
  10. Ævar Arnfjörð BjarmasonJan 12, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.