Re: [PATCH v7 0/4] worktree: Support `--orphan` when creating new worktrees

From: Jacob Abel <jacobabel@nullpo.dev>
Date: Jan 9, 2023, 17:11 UTC
Message-ID: <20230109171100.6jj65aktyohtykid@phi>
In-Reply-To: <230109.86r0w328nu.gmgdl@evledraar.gmail.com>

On 23/01/09 01:26PM, Ævar Arnfjörð Bjarmason wrote:

Show 22 quoted lines

>
> On Sat, Jan 07 2023, Jacob Abel wrote:
>
> > [...]
>
> This round looks good to me, except for a small tiny (and new)
> portability issue that needs fixing:
>
> > [...]
>
> Good to get rid of this.
>
> > [...]
> >     ++		grep -P "fatal:( options)? .* cannot be used together" actual
>
> This is the new unportable code, the "-P" option is specific to GNU
> grep, and here you're relying on the "?" syntax along with other
> ERE-like syntax.
>
> It looks like the minimal fix here is to just change -P to -E, which we
> can use, you're not using any PCRE-syntax, but just syntax that's part
> of ERE.

Understood. I have made the change and prepared a new revision already if this is all that needs to be changed. I can submit it at any time however I was unsure of whether it was considered bad etiquette to submit new revisions so close to each other.