[PATCH] builtin: submodule--helper: Add allocation check of module_cb structure objects may be helpful in case of allocation failure
- From
- Li kunyu <kunyu@nfschina.com>
- Date
- Nov 22, 2022, 03:17 UTC
- Message-ID
- <20221122031739.3440-1-kunyu@nfschina.com>
The purpose of using temp is unknown, but adding an allocation failure report should be helpful.
Signed-off-by: Li kunyu <kunyu@nfschina.com> --- builtin/submodule--helper.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index b63f420ece..2e379623ea 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -1077,6 +1077,9 @@ static void submodule_summary_callback(struct diff_queue_struct *q, if (!S_ISGITLINK(p->one->mode) && !S_ISGITLINK(p->two->mode)) continue; temp = (struct module_cb*)malloc(sizeof(struct module_cb)); + if (!temp) + BUG("The module_cb structure object fails to be allocated and the program may terminate abnormally"); + temp->mod_src = p->one->mode; temp->mod_dst = p->two->mode; temp->oid_src = p->one->oid;
-- 2.18.2