Re: [PATCH 1/3] line-log: free diff queue when processing non-merge commits

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Nov 7, 2022, 15:11 UTC
Message-ID: <20221107151115.GA1951@szeder.dev>
In-Reply-To: <Y2MJRRfwG7rSp6Ra@nand.local>

On Wed, Nov 02, 2022 at 08:20:21PM -0400, Taylor Blau wrote:

Show 13 quoted lines

> > +void diff_free_queue(struct diff_queue_struct *q)
> > +{
> > +	for (int i = 0; i < q->nr; i++)
> > +		diff_free_filepair(q->queue[i]);
> > +	free(q->queue);
> > +}
> 
> Though I wonder, should diff_free_queue() be a noop when q is NULL? The
> caller in process_ranges_ordinary_commit() doesn't care, of course,
> since q is always non-NULL there.
> 
> But if we're making it part of the diff API, we should probably err on
> the side of flexibility.

On one hand, strbuf_reset(), string_list_clear(), or strvec_clear() would all segfault on a NULL strbuf, string_list, or strvec pointer.

On the other hand, given the usage patterns of the diff API, and that it mostly only works on the dreaded global 'diff_queued_diff' instance, I don't think there is any flexibility to be gained with this; indeed it is already more flexible than many diff API functions as it works on the diff queue given as parameter instead of that global instance.