git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: clarify runtime relative gitexecdir

From
Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date
Oct 6, 2022, 01:32 UTC
Message-ID
<20221006013205.15015-1-congdanhqx@gmail.com>
In-Reply-To
<xmqqpmf6nf09.fsf@gitster.g>

"git" built with RUNTIME_PREFIX flag turned on could figure out gitexecdir and other paths as relative to "git" executable.

However, in the section specifies gitexecdir, RUNTIME_PREFIX wasn't mentioned, thus users may wrongly assume that "git" always locates gitexecdir as relative path to the executable.

Let's clarify that only "git" built with RUNTIME_PREFIX will locate gitexecdir as relative path.

Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
---
 Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index cac3452edb..8a58be440f 100644
--- a/Makefile
+++ b/Makefile
@@ -529,8 +529,9 @@ GIT-VERSION-FILE: FORCE
 #   template_dir
 #   sysconfdir
 # can be specified as a relative path some/where/else;
-# this is interpreted as relative to $(prefix) and "git" at
-# runtime figures out where they are based on the path to the executable.
+# this is interpreted as relative to $(prefix) and "git" built with
+# RUNTIME_PREFIX flag will figure out (at runtime) where they are
+# based on the path to the executable.
 # Additionally, the following will be treated as relative by "git" if they
 # begin with "$(prefix)/":
 #   mandir
-- 
2.38.0.1.ge44e9fe867
Previous: Junio C Hamano
Message 7 of 7 in “Install-prefix when building should not be hardcoded”
  1. darkdragonOct 4, 2022
  2. Đoàn Trần Công DanhOct 4, 2022
  3. darkdragonOct 4, 2022
  4. Junio C HamanoOct 5, 2022
  5. darkdragonOct 5, 2022
  6. Junio C HamanoOct 5, 2022
  7. Makefile: clarify runtime relative gitexecdirĐoàn Trần Công Danh, Oct 6, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.