Re: [PATCH v2 4/9] bundle-uri: create base key-value pair parsing

From: Jonathan Tan <jonathantanmy@google.com>
Date: Sep 29, 2022, 21:49 UTC
Message-ID: <20220929214906.1437133-1-jonathantanmy@google.com>
In-Reply-To: <70daef66833744fb8b870f431af8201222c7a2ba.1662734015.git.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 13 quoted lines

> @@ -65,6 +66,81 @@ int for_all_bundles_in_list(struct bundle_list *list,
>  	return 0;
>  }
>  
> +/**
> + * Given a key-value pair, update the state of the given bundle list.
> + * Returns 0 if the key-value pair is understood. Returns 1 if the key
> + * is not understood or the value is malformed.
> + */
> +MAYBE_UNUSED
> +static int bundle_list_update(const char *key, const char *value,
> +			      struct bundle_list *list)
> +{

[snip]

> +	if (parse_config_key(key, "bundle", &subsection, &subsection_len, &subkey))
> +		return -1;

The comment at the top should say -1 instead of 1.