git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] diff-merges: cleanup func_by_opt()

From
Sergey Organov <sorganov@gmail.com>
Date
Sep 14, 2022, 19:31 UTC
Message-ID
<20220914193102.5275-2-sorganov@gmail.com>
In-Reply-To
<20220914193102.5275-1-sorganov@gmail.com>
Get rid of unneeded "else" statements in func_by_opt().
Signed-off-by: Sergey Organov <sorganov@gmail.com>
---
 diff-merges.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/diff-merges.c b/diff-merges.c
index 7f64156b8bfe..780ed08fc87f 100644
--- a/diff-merges.c
+++ b/diff-merges.c
@@ -60,15 +60,15 @@ static diff_merges_setup_func_t func_by_opt(const char *optarg)
 		return suppress;
 	if (!strcmp(optarg, "1") || !strcmp(optarg, "first-parent"))
 		return set_first_parent;
-	else if (!strcmp(optarg, "separate"))
+	if (!strcmp(optarg, "separate"))
 		return set_separate;
-	else if (!strcmp(optarg, "c") || !strcmp(optarg, "combined"))
+	if (!strcmp(optarg, "c") || !strcmp(optarg, "combined"))
 		return set_combined;
-	else if (!strcmp(optarg, "cc") || !strcmp(optarg, "dense-combined"))
+	if (!strcmp(optarg, "cc") || !strcmp(optarg, "dense-combined"))
 		return set_dense_combined;
-	else if (!strcmp(optarg, "r") || !strcmp(optarg, "remerge"))
+	if (!strcmp(optarg, "r") || !strcmp(optarg, "remerge"))
 		return set_remerge_diff;
-	else if (!strcmp(optarg, "m") || !strcmp(optarg, "on"))
+	if (!strcmp(optarg, "m") || !strcmp(optarg, "on"))
 		return set_to_default;
 	return NULL;
 }
-- 
2.25.1
Previous: Sergey OrganovNext: Junio C Hamano
Message 2 of 13 in “diff-merges: minor cleanups”
  1. 0/3 diff-merges: minor cleanupsSergey Organov, Sep 14, 2022
  2. 1/3 diff-merges: cleanup func_by_opt()Sergey Organov, Sep 14, 2022
  3. Junio C HamanoSep 15, 2022
  4. Sergey OrganovSep 16, 2022
  5. Junio C HamanoSep 16, 2022
  6. Sergey OrganovSep 16, 2022
  7. 2/3 diff-merges: cleanup set_diff_merges()Sergey Organov, Sep 14, 2022
  8. Junio C HamanoSep 15, 2022
  9. Sergey OrganovSep 16, 2022
  10. 3/3 diff-merges: clarify log.diffMerges documentationSergey Organov, Sep 14, 2022
  11. Junio C HamanoSep 15, 2022
  12. Sergey OrganovSep 16, 2022
  13. Junio C HamanoSep 16, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.