[PATCH 24/51] completion: zsh: fix extra space on foo=
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Aug 30, 2022, 09:31 UTC
- Message-ID
- <20220830093138.1581538-25-felipe.contreras@gmail.com>
- In-Reply-To
- <20220830093138.1581538-1-felipe.contreras@gmail.com>
Upstream commit e1e00089da fixed the issue for Bash, but not for Zsh.
When we are typing configurations an = at the end signifies we still want to type the value.
Can be tested with:
git -c log.d<tab>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> --- contrib/completion/git-completion.zsh | 2 +- t/t9904-zsh-completion.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh index b062090a13..f732881958 100644 --- a/contrib/completion/git-completion.zsh +++ b/contrib/completion/git-completion.zsh @@ -87,7 +87,7 @@ __gitcomp () fi c="$c${4-}" case $c in - --*=|*.) ;; + *=|*.) ;; *) c="$c " ;; esac array+=("$c") diff --git a/t/t9904-zsh-completion.sh b/t/t9904-zsh-completion.sh index 4c7cf4234e..7283af3342 100755 --- a/t/t9904-zsh-completion.sh +++ b/t/t9904-zsh-completion.sh @@ -1078,7 +1078,7 @@ test_expect_success 'git -c - section' ' EOF ' -test_expect_failure 'git -c - variable name' ' +test_expect_success 'git -c - variable name' ' test_completion "git -c log.d" <<-\EOF log.date=Z log.decorate=Z @@ -1100,7 +1100,7 @@ test_expect_success 'git clone --config= - section' ' EOF ' -test_expect_failure 'git clone --config= - variable name' ' +test_expect_success 'git clone --config= - variable name' ' test_completion "git clone --config=log.d" <<-\EOF log.date=Z log.decorate=Z
-- 2.37.2.351.g9bf691b78c.dirty