git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: `git patch-id --stable' vs quoted-printable

From
EWEric Wong <e@80x24.org>
Date
Aug 22, 2022, 04:57 UTC
Message-ID
<20220822045728.GA453@dcvr>
In-Reply-To
<xmqq7d30gbcd.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> >> So, I'm wondering if the search indexing code of public-inbox
> >> should s/^$/ /mgs before feeding stuff to `git patch-id'; and/or
> >> if `git patch-id' should be assuming empty lines and lines with a
> >> single SP are the same...
> 
> Another potential source of issues (not for the patch from René that
> was used as an example) is that a patch producer can use different
> diff algorithm from the setting you would use to index resulting
> commits via "git show | git patch-id".
> 
>     $ git show -U5 | git patch-id
>     $ git show | git patch-id
> 
> likely result in different patch IDs.  
> 
> The --patience and the --histogram options affect how common lines
> are matched up, again affecting the shape of the patches you compute
> patch-ids over.

Yes, you're right; though I suppose most users use git defaults. I'm not sure how useful patchid ends up being, actually... The old use of dfpre/dfpost blob OIDs seems to have been working well for years, already.

Possibly OR-ing them with patchid in Xapian will end up getting good enough search engine coverage.

Previous: Junio C HamanoNext: René Scharfe
Message 4 of 8 in “`git patch-id --stable' vs quoted-printable”
  1. Eric WongAug 22, 2022
  2. Junio C HamanoAug 22, 2022
  3. Junio C HamanoAug 22, 2022
  4. Eric WongAug 22, 2022
  5. René ScharfeAug 22, 2022
  6. Junio C HamanoAug 22, 2022
  7. Eric WongAug 22, 2022
  8. Junio C HamanoAug 22, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.