git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/3] mergetools: vimdiff: regression fix (vimdiff3 mode)

From
Fernando Ramos <greenfoo@u92.eu>
Date
Aug 8, 2022, 05:34 UTC
Message-ID
<20220808053459.184367-1-greenfoo@u92.eu>
In-Reply-To
<20220807024941.222018-1-felipe.contreras@gmail.com>

Felipe detected that color highlighting no longer worked when running "git mergetools -t vimdiff3".

Deeper inspection of the problem revealed that color highlighting was also not working in other cases (layouts that contained a single window in one of their tabs)

The current patch series fixes the issue by doing two things:
  1. Making single tab + single window modes (such as "vimdiff3") use the same
     code path as all other layouts.
  2. Fixing the general "single window" case so that color highlighting also
     works there (and this is achieved by adding all buffers to the diff group
     in single window tabs).
In other words, after this patch:
  A) Tabs with more than one window will only highlight differences between the
     buffers shown in those windows.
  B) Tabs with just one window (and this also covers the more specific case of
     layouts with just one tab containing one window) will highlight differences
     between all buffers (LOCAL, BASE, REMOTE, MERGED).
Felipe Contreras (1):
  mergetools: vimdiff: fix comment
Fernando Ramos (2):
  mergetools: vimdiff: fix single tab mode, single window mode and
    colors
  mergetools: vimdiff: update unit tests
 mergetools/vimdiff | 109 +++++++++++++++++++++++++++++----------------
 1 file changed, 70 insertions(+), 39 deletions(-)
-- 
2.37.1
Previous: Felipe ContrerasNext: Fernando Ramos
Message 20 of 28 in “mergetools: vimdiff: regression fix and reorg”
  1. 0/9 mergetools: vimdiff: regression fix and reorgFelipe Contreras, Aug 7, 2022
  2. 1/9 mergetools: vimdiff: fix commentFelipe Contreras, Aug 7, 2022
  3. 2/9 mergetools: vimdiff: shuffle single window caseFelipe Contreras, Aug 7, 2022
  4. Fernando RamosAug 7, 2022
  5. Felipe ContrerasAug 7, 2022
  6. 3/9 mergetools: vimdiff: add get_buf() helperFelipe Contreras, Aug 7, 2022
  7. 4/9 mergetools: vimdiff: make vimdiff3 actually workFelipe Contreras, Aug 7, 2022
  8. 6/9 mergetools: vimdiff: fix for diffoptFelipe Contreras, Aug 7, 2022
  9. 5/9 mergetools: vimdiff: silence annoying messagesFelipe Contreras, Aug 7, 2022
  10. 7/9 mergetools: vimdiff: cleanup cruftFelipe Contreras, Aug 7, 2022
  11. 8/9 mergetools: vimdiff: fix single window modeFelipe Contreras, Aug 7, 2022
  12. 9/9 mergetools: vimdiff: use vimdiff for vimdiff3Felipe Contreras, Aug 7, 2022
  13. Fernando RamosAug 7, 2022
  14. Fernando RamosAug 7, 2022
  15. Felipe ContrerasAug 7, 2022
  16. Fernando RamosAug 7, 2022
  17. 1/2 vimdiff: fix single tab mode, single window mode and colorsFernando Ramos, Aug 7, 2022
  18. 2/2 vimdiff: update unit testsFernando Ramos, Aug 7, 2022
  19. Felipe ContrerasAug 7, 2022
  20. 0/3 mergetools: vimdiff: regression fix (vimdiff3 mode)Fernando Ramos, Aug 8, 2022
  21. 1/3 mergetools: vimdiff: fix commentFernando Ramos, Aug 8, 2022
  22. 2/3 mergetools: vimdiff: fix single tab mode, single window mode and colorsFernando Ramos, Aug 8, 2022
  23. Felipe ContrerasAug 8, 2022
  24. Fernando RamosAug 8, 2022
  25. Felipe ContrerasAug 8, 2022
  26. Fernando RamosAug 8, 2022
  27. Felipe ContrerasAug 9, 2022
  28. 3/3 mergetools: vimdiff: update unit testsFernando Ramos, Aug 8, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.