Re: [RFC PATCH] gitweb: improve title shortening heuristics
Hi,
On Tue, Jul 26, 2022 at 11:31:32PM -0700, Junio C Hamano wrote:
Show 17 quoted lines
>
> When you are sending the patch in for real, after making a non-patch
> discussion (all of the above), you can write a "scissors" line
>
> ----- >8 -----
>
> right here, immediately before your "From:" and "Subject:". What it
> does is to tell "git am" on the receiving end to ignore everything
> it saw up to that point and pretend the message starts there.
>
> You do not want to include "From <object name>" line that is used as
> an internal separator in the mailbox format. You do not want to
> include the "Date:" in-body header, either. "From:" and "Subject:"
> are used often because they are frequently different from the e-mail
> (e.g. in the message I am responding to, the sender is rjuju123@gmail,
> not julien.rouhaud@free.fr, and we want the latter on the From: line
> because that is what appears on the Signed-off-by: line).
Show 15 quoted lines
> > From: Julien Rouhaud <julien.rouhaud@free.fr>
> > Subject: [PATCH v2] gitweb: Remove title_short shortening heuristics
> >
> > Those heuristics are way outdated and too general to be useful outside of
> > kernel.org. Since kernel.org doesn't use gitweb anymore and at least one
> > project complained about incorrect behavior, entirely remove them.
> >
> > Signed-off-by: Julien Rouhaud <julien.rouhaud@free.fr>
> > ---
> >
> > Notes:
> > Patch re-submitted inline rather than in attachment, sorry about the
> > previous attachments.
>
> Thanks. Will queue.