git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] tr2: shows scope unconditionally in addition to key-value pair

From
tenglong.tl <dyroneteng@gmail.com>
Date
Jul 22, 2022, 06:12 UTC
Message-ID
<20220722061240.9348-1-tenglong.tl@alibaba-inc.com>
In-Reply-To
<xmqqh73ajteh.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 16 quoted lines
> Everything in these examples use concrete values and follow the real
> syntax (e.g. param is enclosed in double-quotes and so is its value
> core.abbrev; even though core.abbrev is not the only param that can
> be reported by a def-param event, it is used as a concrete example.
> The same story goes for value).  The new "scope" thing stands out
> like a sore thumb.  I think the above should read more like
>
> 	"event":"def_param",
> 	...
> 	"scope":"global",
> 	"param":"core.abbrev",
> 	"value":"7"
>
> or something.  Pick your favourite value for scope.
>
> Other than that, these two patches make quite a lot of sense.

Yes. I think you are right, in this context, we should obey the same syntax and will fix in next patch.

Thanks.
Previous: Junio C HamanoNext: tenglong.tl
Message 5 of 22 in “tr2: shows the scope unconditionally with config”
  1. 0/2 tr2: shows the scope unconditionally with configtenglong.tl, Jul 21, 2022
  2. 1/2 api-trace2.txt: print config key-value pairtenglong.tl, Jul 21, 2022
  3. 2/2 tr2: shows scope unconditionally in addition to key-value pairtenglong.tl, Jul 21, 2022
  4. Junio C HamanoJul 21, 2022
  5. tenglong.tlJul 22, 2022
  6. 0/2 tr2: shows the scope unconditionally with configtenglong.tl, Jul 22, 2022
  7. 1/2 api-trace2.txt: print config key-value pairtenglong.tl, Jul 22, 2022
  8. Ævar Arnfjörð BjarmasonJul 22, 2022
  9. Junio C HamanoJul 25, 2022
  10. tenglong.tlAug 1, 2022
  11. Junio C HamanoAug 5, 2022
  12. Teng LongAug 8, 2022
  13. Junio C HamanoJul 22, 2022
  14. tenglong.tlJul 23, 2022
  15. Junio C HamanoJul 23, 2022
  16. tenglong.tlJul 25, 2022
  17. 2/2 tr2: shows scope unconditionally in addition to key-value pairtenglong.tl, Jul 22, 2022
  18. 0/2 tr2: shows the scope unconditionally with configTeng Long, Aug 12, 2022
  19. 1/2 api-trace2.txt: print config key-value pairTeng Long, Aug 12, 2022
  20. 2/2 tr2: shows scope unconditionally in addition to key-value pairTeng Long, Aug 12, 2022
  21. Junio C HamanoAug 12, 2022
  22. Junio C HamanoAug 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.