git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] midx.c: clean up .rev file

From
Teng Long <dyroneteng@gmail.com>
Date
Jun 23, 2022, 12:38 UTC
Message-ID
<20220623123819.2388-1-dyroneteng@gmail.com>
In-Reply-To
<YrNb2x2/7Z31XnFJ@nand.local>
On Wed, Wed, 22 Jun 2022 14:13:47 -0400, Taylor Blay wrote:
Show 7 quoted lines
> It shouldn't in practice. We'll recognize that the .rev file is garbage
> if it's checksum doesn't match the MIDX's, and we squashed the bug where
> changing the object *order* (but not the objects themselves) doesn't
> change the MIDX checksum (it does now).
> 
> We won't write over an existing .rev file with the right name, but we'll
> always prefer to read the .rev data from the MIDX itself, if it exists.
Yes, this is what I want to say.

On the patch itself, I think it may worth to remove the tmp rev file at earlier time because there may reduce doubt about whether the file remaining after the interruption will have side effects (but we know it won't for now , because regenerating midx and rev will ensure an strict match based on the checksum).

Thanks.
Previous: Xiaowen XiaNext: Xiaowen Xia
Message 8 of 9 in “midx.c: clean up .rev file”
  1. midx.c: clean up .rev filehaoyurenzhuxia@gmail.com, Jun 22, 2022
  2. Ævar Arnfjörð BjarmasonJun 22, 2022
  3. Junio C HamanoJun 22, 2022
  4. Taylor BlauJun 22, 2022
  5. Junio C HamanoJun 22, 2022
  6. Taylor BlauJun 22, 2022
  7. Xiaowen XiaJun 27, 2022
  8. Teng LongJun 23, 2022
  9. Xiaowen XiaJun 27, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.