git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] fetch,fetch-pack: clarify connectivity check error

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Jun 17, 2022, 20:03 UTC
Message-ID
<20220617200301.2700839-1-jonathantanmy@google.com>
In-Reply-To
<xmqqr13wclll.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 12 quoted lines
> While that is all true, I do not think the posted patch as-is is a
> good idea.  After all, object missing on our side locally before you
> start "git fetch" is a local repository corruption, which ought to
> be a much rarer event than a still in development and in flux server
> end sending nonsense packfiles, no?
> 
> At least, "they didn't do X" would give the user somewhere to start
> investigation (e.g. complain to the server folks about the error,
> stating where they started from and what they tried to fetch).  The
> new message may be playing it "safe" by not saying anything you are
> not absolutely sure about, but that is much less useful to the users
> who got the message.

Hmm...that's true. Let me try to understand the revision walking code a bit more, and if by then I still don't end up changing the revision walk to avoid prematurely parsing a parent, I'll make a patch with your suggestion.

Previous: Junio C Hamano
Message 9 of 9 in “connected: distinguish local/remote bad objects”
  1. connected: distinguish local/remote bad objectsJonathan Tan, Jun 8, 2022
  2. Junio C HamanoJun 8, 2022
  3. Jonathan TanJun 9, 2022
  4. Junio C HamanoJun 9, 2022
  5. Jonathan TanJun 9, 2022
  6. Ævar Arnfjörð BjarmasonJun 9, 2022
  7. fetch,fetch-pack: clarify connectivity check errorJonathan Tan, Jun 10, 2022
  8. Junio C HamanoJun 10, 2022
  9. Jonathan TanJun 17, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.