git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re: [PATCH] remote-curl: send Accept-Language header to server

From
Llilinchao@oschina.cn <lilinchao@oschina.cn>
Date
Jun 10, 2022, 02:38 UTC
Message-ID
<2022061010332322021051@oschina.cn>
In-Reply-To
<220609.86leu6thon.gmgdl@evledraar.gmail.com>
Sorry, I mistakenly sent the reply email to you yesterday, I should click "Reply all" button :(
Show 19 quoted lines
>
>On Wed, Jun 08 2022, Li Linchao via GitGitGadget wrote:
>
>> From: Cactusinhand <lilinchao@oschina.cn>
>>
>> Git server end's ability to accept Accept-Language header was introduced
>> in f18604bbf2(http: add Accept-Language header if possible), but this is
>> only used by very early phase of the transfer, that's HTTP GET request to
>> discover references. For other phases, like POST request in the smart HTTP
>> the server side don't know what language client speak.
>>
>> This patch teaches git client to learn end-user's preferred language and
>> throw accept-language header to server side. Once server get this header
>> it have ability to talk to end-user with language they understand, this
>> would be very helpful for many non-English speakers.
>
>I may be missing something, but this is just the "Accept-Language" part
>of this change, i.e. there is no "round-tripping" here of actually doing
>the work on the server of doing setlocale(), no?

Yes,  here Git just holds this header message, and the actual work depends on the git service providers, like Github, Gitlab, or Gitee. 

Show 5 quoted lines
>
>I think the end-goal of having the "remote: " messages translated, if
>possible, is very worthwhile, but I'd always imagined we'd do that with
>a protocol extension, because even if we do this with HTTP headers we
>won't get the same over ssh/git transports.
As for ssh transport, can we use ssh environment to reach our goal?
Show 5 quoted lines
>
>But then again we don't have protocol v2 push yet :(
>
>So perfect certainly shouldn't be the enemy of the good here, I just
>wonder what the end-goal is and if there's a plan to get there.
Thanks.
Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 20 in “remote-curl: send Accept-Language header to server”
  1. remote-curl: send Accept-Language header to serverLi Linchao via GitGitGadget, Jun 8, 2022
  2. Junio C HamanoJun 8, 2022
  3. remote-curl: send Accept-Language header to serverLi Linchao via GitGitGadget, Jun 9, 2022
  4. Junio C HamanoJun 9, 2022
  5. lilinchao@oschina.cnJun 10, 2022
  6. lilinchao@oschina.cnJun 10, 2022
  7. remote-curl: send Accept-Language header to serverLi Linchao via GitGitGadget, Jun 12, 2022
  8. Junio C HamanoJun 13, 2022
  9. Junio C HamanoJun 13, 2022
  10. Junio C HamanoJun 13, 2022
  11. Junio C HamanoJun 13, 2022
  12. remote-curl: send Accept-Language header to serverLi Linchao via GitGitGadget, Jul 11, 2022
  13. Ævar Arnfjörð BjarmasonJun 9, 2022
  14. Junio C HamanoJun 9, 2022
  15. lilinchao@oschina.cnJun 10, 2022
  16. Junio C HamanoJul 3, 2022
  17. lilinchao@oschina.cnJul 5, 2022
  18. Ævar Arnfjörð BjarmasonJul 5, 2022
  19. Junio C HamanoJul 5, 2022
  20. Junio C HamanoJul 5, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.