Re: [PATCH 1/2] dir.c: avoid gcc warning

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: May 7, 2022, 06:14 UTC
Message-ID: <20220507061401.onpbrd35w5xjrrh6@carlos-mbp.lan>
In-Reply-To: <cd50ec73ddafaaeba04298ae79cbf625cc0d7697.1651859773.git.git@grubix.eu>

On Fri, May 06, 2022 at 08:04:05PM +0200, Michael J Gruber wrote:

> Related to -Wstringop-overread.
> 
> In fact, this may be a false positive

Indeed it seems more like a bug[1] in gcc12, probably with their optimizer.

Getting to the bottom of it with a minimized version of the code that would trigger it would be a good way to help it move forward instead of "fixing" git's codebase IMHO.

It would be also nice if someone from the gcc team would confirm or deny if this is indeed something worth waiting for a fix on their side, or would need some workaround in ours, or maybe even a real fix.

FWIW there is already a workaround of sorts in our codebase since 846a29afb0 (config.mak.dev: workaround gcc 12 bug affecting "pedantic" CI job, 2022-04-15) so that this warning should be expected when building with DEVELOPER=1 but it won't break the build as it would normally do.

Carlo

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2075786