git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Failures in t9001-send-email

From
Alyssa Ross <hi@alyssa.is>
Date
Apr 21, 2022, 22:38 UTC
Message-ID
<20220421223843.6z3y4bnrbu76erhk@eve>
In-Reply-To
<220421.86tuam5hoi.gmgdl@evledraar.gmail.com>
Show 9 quoted lines
> I think a patch to do that would be worth having/reviewing (hint
> hint!). As always the real work is updating docs, running the tests
> etc., digging up ML discussions to see if there's been any past
> arguments for/against it etc.
>
> In this case the code change itself should be trivial (I honestly didn't
> look this time, but really, it's a config default...). So this seems
> like a perfect task for someone not too familiar with Git's codebase,
> but still interested in contributing :)

I thought I'd have a go at a patch, but I wasn't able to get the tests running:

    prove ./t9001-send-email.sh
    ./t9001-send-email.sh .. Dubious, test returned 1 (wstat 256, 0x100)
    Failed 15/188 subtests
      (less 1 skipped subtest: 172 okay)
    Test Summary Report
    -------------------
    ./t9001-send-email.sh (Wstat: 256 Tests: 188 Failed: 15)
      Failed tests:  27, 51, 78-84, 123, 147-150, 185
      Non-zero exit status: 1
    Files=1, Tests=188, 17 wallclock secs ( 0.06 usr  0.01 sys + 11.66 cusr  5.37 csys = 17.10 CPU)
    Result: FAIL

I had a look at the tests to try to guess what was wrong, but I didn't come up with anything. Any ideas? When I run make test, every other test is fine, it's just the send-email tests that are problematic.

(My git source tree is v2.36.0.)
Previous: Junio C HamanoNext: rsbecker@nexbridge.com
Message 4 of 15 in “Should sendemail.confirm default to always?”
  1. Alyssa RossApr 21, 2022
  2. Ævar Arnfjörð BjarmasonApr 21, 2022
  3. Junio C HamanoApr 21, 2022
  4. Failures in t9001-send-emailAlyssa Ross, Apr 21, 2022
  5. rsbecker@nexbridge.comApr 21, 2022
  6. Alyssa RossApr 22, 2022
  7. rsbecker@nexbridge.comApr 22, 2022
  8. Johannes SixtApr 22, 2022
  9. Junio C HamanoApr 22, 2022
  10. Alyssa RossApr 22, 2022
  11. send-email: always confirm by defaultAlyssa Ross, Apr 22, 2022
  12. Ævar Arnfjörð BjarmasonApr 22, 2022
  13. Junio C HamanoApr 22, 2022
  14. Junio C HamanoApr 21, 2022
  15. Alyssa RossApr 21, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.