git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 18/22] git-p4: compare to singletons with "is" and "is not"

From
Joel Holdsworth <jholdsworth@nvidia.com>
Date
Apr 1, 2022, 14:25 UTC
Message-ID
<20220401142504.58995-19-jholdsworth@nvidia.com>
In-Reply-To
<20220401142504.58995-1-jholdsworth@nvidia.com>

PEP8 recommends that comparisons with singletons such as None should be done with "is" and "is not", and never equality operators.

This guideline is described here: https://www.python.org/dev/peps/pep-0008/#programming-recommendations

Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
---
 git-p4.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index a25adc8bae..2f2450f7d9 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -857,7 +857,7 @@ def p4Where(depotPath):
             if data[:space] == depotPath:
                 output = entry
                 break
-    if output == None:
+    if output is None:
         return ""
     if output["code"] == "error":
         return ""
@@ -879,7 +879,7 @@ def currentGitBranch():
 
 
 def isValidGitDir(path):
-    return git_dir(path) != None
+    return git_dir(path) is not None
 
 
 def parseRevision(ref):
@@ -4425,7 +4425,7 @@ def main():
     global verbose
     verbose = cmd.verbose
     if cmd.needsGit:
-        if cmd.gitdir == None:
+        if cmd.gitdir is None:
             cmd.gitdir = os.path.abspath(".git")
             if not isValidGitDir(cmd.gitdir):
                 # "rev-parse --git-dir" without arguments will try $PWD/.git
-- 
2.35.GIT
Previous: Joel HoldsworthNext: Joel Holdsworth
Message 6 of 25 in “git-p4: Various code tidy-ups”
  1. 00/22 git-p4: Various code tidy-upsJoel Holdsworth, Apr 1, 2022
  2. 11/22 git-p4: place a single space after every commaJoel Holdsworth, Apr 1, 2022
  3. 12/22 git-p4: remove extraneous spaces before function argumentsJoel Holdsworth, Apr 1, 2022
  4. 15/22 git-p4: ensure every comment has a single #Joel Holdsworth, Apr 1, 2022
  5. 16/22 git-p4: ensure there is a single space around all operatorsJoel Holdsworth, Apr 1, 2022
  6. 18/22 git-p4: compare to singletons with "is" and "is not"Joel Holdsworth, Apr 1, 2022
  7. 19/22 git-p4: only seperate code blocks by a single empty lineJoel Holdsworth, Apr 1, 2022
  8. 17/22 git-p4: normalize indentation of lines in conditionalsJoel Holdsworth, Apr 1, 2022
  9. 13/22 git-p4: remove redundant backslash-continuations inside bracketsJoel Holdsworth, Apr 1, 2022
  10. 20/22 git-p4: move inline comments to line aboveJoel Holdsworth, Apr 1, 2022
  11. 14/22 git-p4: remove spaces between dictionary keys and colonsJoel Holdsworth, Apr 1, 2022
  12. 22/22 git-p4: sort importsJoel Holdsworth, Apr 1, 2022
  13. 21/22 git-p4: seperate multiple statements onto seperate linesJoel Holdsworth, Apr 1, 2022
  14. 08/22 git-p4: remove padding from lists, tuples and function argumentsJoel Holdsworth, Apr 1, 2022
  15. 02/22 git-p4: remove unneeded semicolons from statementsJoel Holdsworth, Apr 1, 2022
  16. 07/22 git-p4: sort and de-duplcate pylint disable listJoel Holdsworth, Apr 1, 2022
  17. 09/22 git-p4: remove spaces around default argumentsJoel Holdsworth, Apr 1, 2022
  18. 03/22 git-p4: indent with 4-spacesJoel Holdsworth, Apr 1, 2022
  19. 10/22 git-p4: removed brackets when assigning multiple return valuesJoel Holdsworth, Apr 1, 2022
  20. 01/22 git-p4: add blank lines between functions and class definitionsJoel Holdsworth, Apr 1, 2022
  21. 04/22 git-p4: improve consistency of docstring formattingJoel Holdsworth, Apr 1, 2022
  22. 06/22 git-p4: remove commented codeJoel Holdsworth, Apr 1, 2022
  23. 05/22 git-p4: convert descriptive class and function comments into docstringsJoel Holdsworth, Apr 1, 2022
  24. Tao KlerksApr 10, 2022
  25. Junio C HamanoApr 11, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.