[PATCH 1/2] branch: rework comments for future developers
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 31, 2022, 22:41 UTC
- Message-ID
- <20220331224118.3014407-1-gitster@pobox.com>
- In-Reply-To
- <xmqq7d89zqys.fsf@gitster.g>
From: Glen Choo <chooglen@google.com>
For two cases in which we do not explicitly pass --track=<choice> option down to the submodule--helper subprocess, we have comments that say "we do not have to pass --track", but in fact we not just do not have to, but it would be incorrect to pass any --track option to the subprocess (instead, the correct behaviour is to let the subprocess figure out what is the appropriate tracking mode to use).
Signed-off-by: Glen Choo <chooglen@google.com> --- branch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/branch.c b/branch.c index ed6f993aa6..8ee9f43539 100644 --- a/branch.c +++ b/branch.c @@ -549,9 +549,9 @@ static int submodule_create_branch(struct repository *r, strvec_push(&child.args, "--track=inherit"); break; case BRANCH_TRACK_UNSPECIFIED: - /* Default for "git checkout". No need to pass --track. */ + /* Default for "git checkout". Do not pass --track. */ case BRANCH_TRACK_REMOTE: - /* Default for "git branch". No need to pass --track. */ + /* Default for "git branch". Do not pass --track. */ break; }
-- 2.35.1-917-g7c4048624a