git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit-reach: do not parse and iterate minima

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Mar 24, 2022, 22:21 UTC
Message-ID
<20220324222115.1327778-1-jonathantanmy@google.com>
In-Reply-To
<a4656826-aecb-d752-7ce7-2ce7a37c7b00@github.com>
Derrick Stolee <derrickstolee@github.com> writes:
Show 21 quoted lines
> On 3/23/2022 5:08 PM, Jonathan Tan wrote:
> >  test_expect_success 'fetch --update-shallow' '
> > +	git init a-submodule &&
> > +	test_commit -C a-submodule foo &&
> 
> You add a submodule here so you can trigger the bug in this test, but...
> 
> >  test_expect_success 'fetch --update-shallow into a repo with submodules' '
> > -	git init a-submodule &&
> > -	test_commit -C a-submodule foo &&
> 
> This test was already named to be specific to submodules. The test names
> could probably use an update to describe what's really the difference
> between the two tests.
> 
> Is there a reason we couldn't trigger the failure only in this second
> test, allowing us to still test --update-shallow when submodules are NOT
> present?
> 
> Thanks,
> -Stolee

I tried but somehow couldn't figure out the correct server and client state to trigger this. If I can't think of anything else, I might just "cp -r" both repos before the "fetch --update-shallow" and that might do the trick.

Previous: Derrick StoleeNext: Jonathan Tan
Message 10 of 16 in “commit-reach: do not parse and iterate minima”
  1. commit-reach: do not parse and iterate minimaJonathan Tan, Mar 23, 2022
  2. Junio C HamanoMar 23, 2022
  3. Derrick StoleeMar 24, 2022
  4. Taylor BlauMar 24, 2022
  5. Derrick StoleeMar 25, 2022
  6. Jonathan TanMar 24, 2022
  7. Bagas SanjayaMar 24, 2022
  8. Jonathan TanMar 24, 2022
  9. Derrick StoleeMar 24, 2022
  10. Jonathan TanMar 24, 2022
  11. commit,shallow: unparse commits if grafts changedJonathan Tan, Jun 2, 2022
  12. Ævar Arnfjörð BjarmasonJun 3, 2022
  13. Derrick StoleeJun 3, 2022
  14. Jonathan TanJun 3, 2022
  15. Jonathan TanJun 3, 2022
  16. commit,shallow: unparse commits if grafts changedJonathan Tan, Jun 6, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.