git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 12/41] pull.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status

From
Elia Pinto <gitter.spiros@gmail.com>
Date
Mar 21, 2022, 22:54 UTC
Message-ID
<20220321225523.724509-13-gitter.spiros@gmail.com>
In-Reply-To
<20220321225523.724509-1-gitter.spiros@gmail.com>

The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may be passed to exit() to indicate successful or unsuccessful termination, respectively. The value of status in exit(status) may be EXIT_SUCCESS, EXIT_FAILURE, or any other value, though only the least significant 8 bits (that is, status & 0377) shall be available to a waiting parent proces. So exit(-1) return 255.

Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit status instead of "0" or "1", respectively. In <stdlib.h> EXIT_FAILURE has the value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for consistency.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 builtin/pull.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/pull.c b/builtin/pull.c
index 4d667abc19..3b16e891ea 100644
--- a/builtin/pull.c
+++ b/builtin/pull.c
@@ -489,7 +489,7 @@ static void NORETURN die_no_merge_candidates(const char *repo, const char **refs
 		fprintf_ln(stderr, _("Your configuration specifies to merge with the ref '%s'\n"
 			"from the remote, but no such ref was fetched."),
 			*curr_branch->merge_name);
-	exit(1);
+	exit(EXIT_FAILURE);
 }
 
 /**

-- 
2.35.1
Previous: Elia PintoNext: Elia Pinto
Message 19 of 48 in “use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status”
  1. 00/41 use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  2. 07/41 help.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  3. 13/41 rebase.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  4. 34/41 setup.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  5. 05/41 commit.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  6. 02/41 branch.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  7. 40/41 upload-pack.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  8. 32/41 remote-curl.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  9. 27/41 git.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  10. 26/41 daemon.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  11. 41/41 exit.cocci: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  12. 01/41 archive.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  13. 24/41 git-credential-osxkeychain.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  14. 20/41 tag.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  15. 09/41 mailsplit.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  16. 38/41 test-submodule-config.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  17. 11/41 merge.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  18. 17/41 shortlog.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  19. 12/41 pull.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  20. 37/41 test-reach.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  21. 33/41 run-command.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  22. 16/41 rm.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  23. 31/41 path.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  24. 04/41 blame.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  25. 15/41 rev-parse.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  26. 29/41 http-backend.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  27. 18/41 show-branch.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  28. 03/41 am.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  29. 36/41 test-json-writer.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  30. 28/41 help.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  31. 39/41 test-submodule-nested-repo-config.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  32. 06/41 credential-cache--daemon.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  33. 14/41 remote-ext.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  34. 10/41 merge-index.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  35. 25/41 git-credential-wincred.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  36. 22/41 update-index.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  37. 08/41 init-db.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  38. 23/41 obstack.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  39. 21/41 unpack-objects.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  40. 30/41 parse-options.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  41. 19/41 stash.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  42. 35/41 shell.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit statusElia Pinto, Mar 21, 2022
  43. Bagas SanjayaMar 22, 2022
  44. Elia PintoMar 22, 2022
  45. Bagas SanjayaMar 22, 2022
  46. Ævar Arnfjörð BjarmasonMar 22, 2022
  47. Elia PintoMar 22, 2022
  48. Junio C HamanoMar 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.