git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ls-files: support --recurse-submodules --stage

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Feb 24, 2022, 00:11 UTC
Message-ID
<20220224001143.2150137-1-jonathantanmy@google.com>
In-Reply-To
<220221.86ley4aw88.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 22 quoted lines
> 
> On Mon, Feb 21 2022, Junio C Hamano wrote:
> > I think what this is trying to make sure is that it (1) enabled the
> > combination and (2) uses the object store of the submodule when
> > disambiguating names of the objects from the submodule, because the
> > author suspects that the reason why these two options were made
> > incompatible in the first place was because long time ago there
> > wasn't a way to ask "here is an object name---please uniquify in the
> > context of _that_ repository".  So it is understandable to prepare
> > an object X in a submodule and another object Y in the superproject,
> > such that the abbreviated name of X in the context of the submodule
> > is different from the abbreviated name of X in the context of the
> > superproject (i.e. if X were in the superproject's object store,
> > because the object names of X and Y share the prefix, it may require
> > longer prefix to disambiguate from Y), and make sure that the uniquify
> > is indeed happening in the context of the submodule.
> >
> > So, you are only concentrating on (1) but forgetting why the author
> > wants (2).
> 
> Indeed. That makes sense, but it would really help to e.g. have the test
> description make that goal explicit.

That indeed was why I did that (thanks, Junio). It looks like it doesn't work with other hash algorithms, and maybe it's too much paranoia on my part. I'll send an updated version following Ævar's suggestion.

Previous: Ævar Arnfjörð BjarmasonNext: Junio C Hamano
Message 7 of 10 in “ls-files: support --recurse-submodules --stage”
  1. ls-files: support --recurse-submodules --stageJonathan Tan, Feb 18, 2022
  2. Junio C HamanoFeb 19, 2022
  3. Ævar Arnfjörð BjarmasonFeb 19, 2022
  4. Taylor BlauFeb 19, 2022
  5. Junio C HamanoFeb 21, 2022
  6. Ævar Arnfjörð BjarmasonFeb 21, 2022
  7. Jonathan TanFeb 24, 2022
  8. Junio C HamanoFeb 21, 2022
  9. Taylor BlauFeb 21, 2022
  10. ls-files: support --recurse-submodules --stageJonathan Tan, Feb 24, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.