git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] clean: avoid looking for nested repositories when unnecessary

From
PMPatrick Marlier <patrick.marlier@gmail.com>
Date
Feb 21, 2022, 09:00 UTC
Message-ID
<20220221090034.4615-1-patrick.marlier@gmail.com>
With `git clean --ff` we will be deleting nested untracked repositories,
so there is no need to differentiate them from other untracked files.
Use the DIR_NO_GITLINKS flag in dir.flags to signify this and avoid the
is_nonbare_repository_dir() checks.
---
 builtin/clean.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/builtin/clean.c b/builtin/clean.c
index 3ff02bbbff..18b37e3fd9 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -955,9 +955,10 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
 				  " refusing to clean"));
 	}
 
-	if (force > 1)
+	if (force > 1) {
 		rm_flags = 0;
-	else
+		dir.flags |= DIR_NO_GITLINKS;
+	} else
 		dir.flags |= DIR_SKIP_NESTED_GIT;
 
 	dir.flags |= DIR_SHOW_OTHER_DIRECTORIES;
-- 
2.35.1
Next: Patrick Marlier
Message 1 of 3 in “clean: avoid looking for nested repositories when unnecessary”
  1. 1/2 clean: avoid looking for nested repositories when unnecessaryPatrick Marlier, Feb 21, 2022
  2. 2/2 clean: avoid traversing into untracked dirs when unnecessaryPatrick Marlier, Feb 21, 2022
  3. Elijah NewrenFeb 22, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.