Re: [PATCH 6/6] fetch: make `--atomic` flag cover pruning of refs

From: Jonathan Tan <jonathantanmy@google.com>
Date: Feb 16, 2022, 23:39 UTC
Message-ID: <20220216233915.1975217-1-jonathantanmy@google.com>
In-Reply-To: <682f16117b743bec59c533e15ae5a88d39250222.1644565025.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 16 quoted lines

> diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
> index 93a0db3c68..afa6bf9f7d 100755
> --- a/t/t5510-fetch.sh
> +++ b/t/t5510-fetch.sh
> @@ -349,11 +349,9 @@ test_expect_success 'fetch --atomic --prune executes a single reference transact
>  	cat >expected <<-EOF &&
>  		prepared
>  		$ZERO_OID $ZERO_OID refs/remotes/origin/scheduled-for-deletion
> -		committed
> -		$ZERO_OID $ZERO_OID refs/remotes/origin/scheduled-for-deletion
> -		prepared
>  		$ZERO_OID $head_oid refs/remotes/origin/new-branch
>  		committed
> +		$ZERO_OID $ZERO_OID refs/remotes/origin/scheduled-for-deletion
>  		$ZERO_OID $head_oid refs/remotes/origin/new-branch
>  	EOF

I think that there is a comment above this change that needs to be deleted too.

Overall, I think that this patch set is a good change, and I have no further comments. (Regarding patch 5, I can't think of a better way to know what refs are duplicates.)