git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwd

From
Bagas Sanjaya <bagasdotme@gmail.com>
Date
Feb 10, 2022, 02:41 UTC
Message-ID
<20220210024138.157327-1-bagasdotme@gmail.com>

Use past tense form of "to remove" and "to skip". This is especially true when we had already removed an entry.

Link:
https://lore.kernel.org/git/CAKQMxzSQRL-Q5daxETF+gYhVScmq_n=r2LJAeEuxpM7=jPajZQ@mail.gmail.com/T/#u
Reported-by: Patrick Marlier <patrick.marlier@gmail.com>
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
 builtin/clean.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/clean.c b/builtin/clean.c
index 3ff02bbbff..f1cd114ee2 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -30,13 +30,13 @@ static const char *const builtin_clean_usage[] = {
 	NULL
 };
 
-static const char *msg_remove = N_("Removing %s\n");
+static const char *msg_remove = N_("Removed %s\n");
 static const char *msg_would_remove = N_("Would remove %s\n");
-static const char *msg_skip_git_dir = N_("Skipping repository %s\n");
+static const char *msg_skip_git_dir = N_("Skipped repository %s\n");
 static const char *msg_would_skip_git_dir = N_("Would skip repository %s\n");
 static const char *msg_warn_remove_failed = N_("failed to remove %s");
 static const char *msg_warn_lstat_failed = N_("could not lstat %s\n");
-static const char *msg_skip_cwd = N_("Refusing to remove current working directory\n");
+static const char *msg_skip_cwd = N_("Refused to remove current working directory\n");
 static const char *msg_would_skip_cwd = N_("Would refuse to remove current working directory\n");
 
 enum color_clean {

base-commit: 2b9c1209706bc2ef0ab09fb0bdc7d405e225ce8b
-- 
An old man doll... just what I always wanted! - Clara
Next: Patrick Marlier
Message 1 of 4 in “clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwd”
  1. clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwdBagas Sanjaya, Feb 10, 2022
  2. Patrick MarlierFeb 12, 2022
  3. Elijah NewrenFeb 12, 2022
  4. Junio C HamanoFeb 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.