git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] promisor-remote.c: use oidset for deduplication

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Jan 25, 2022, 19:17 UTC
Message-ID
<20220125191701.2649292-1-jonathantanmy@google.com>
In-Reply-To
<E5AD42A3-AEAC-44F8-B223-90E2ACAEFCB0@gmail.com>
John Cai <johncai86@gmail.com> writes:
> Jonathan, how often do we expect diff to pass duplicate oids to
> promisor_remote_get_direct()?

I don't recall all the details, but not often, I believe. In a partial clone, I envision that you would typically diff one tree that you have all blobs for and one tree that you don't (or two trees that you have all blobs for). If a user is in a sparse checkout and/or they're diffing two trees that they have never checked out, I would recommend disabling inexact copy detection to reduce the number of blobs that Git would need to fetch. In these cases, I think that diff would only pass duplicate OIDs if one of the trees references the same object more than once (directly or indirectly).

Previous: John Cai
Message 7 of 7 in “promisor-remote.c: use oidset for deduplication”
  1. promisor-remote.c: use oidset for deduplicationJohn Cai via GitGitGadget, Jan 13, 2022
  2. Junio C HamanoJan 13, 2022
  3. Ævar Arnfjörð BjarmasonJan 14, 2022
  4. Junio C HamanoJan 14, 2022
  5. Junio C HamanoJan 14, 2022
  6. John CaiJan 24, 2022
  7. Jonathan TanJan 25, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.