git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] sparse-checkout: create leading directory

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Jan 24, 2022, 18:25 UTC
Message-ID
<20220124182500.2439823-1-jonathantanmy@google.com>
In-Reply-To
<220124.86zgnlgyjr.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 18 quoted lines
> The first thing I said in this thread is "Thanks. This fix looks good to
> me.". I'd be happy to have just this fix in. This patch resolves a
> blocked of an earlier series of mine.
> 
> The rest of the feedback here (aside from the trivial "rm -rf" fix) was
> an attempt to bridge the gap between this & my earlier look in [1].
> 
> > And I think I'd say the same thing even if I saw your tests as being
> > much more closely related to what Jonathan was checking.
> >
> > That's my $0.02 on "why not?".  The story totally changes if you want
> > to submit these tests separate from Jonathan's series.  If that's the
> > scenario, then I fully agree with you on "it's cheap to add more test
> > coverage so why not include it?"
> 
> Sure, or maybe he'd be interested, or not. I'd rather try to suggest
> some small proposed changes than submit a patch of my own as an initial
> approach.

If my patch is OK going in on its own, I'd rather do that, and leave additional changes to other patch sets.

Previous: Ævar Arnfjörð BjarmasonNext: Elijah Newren
Message 11 of 14 in “sparse-checkout: create leading directory”
  1. sparse-checkout: create leading directoryJonathan Tan, Jan 20, 2022
  2. Junio C HamanoJan 20, 2022
  3. Ævar Arnfjörð BjarmasonJan 20, 2022
  4. SZEDER GáborJan 22, 2022
  5. sparse-checkout: create leading directoryJonathan Tan, Jan 21, 2022
  6. Ævar Arnfjörð BjarmasonJan 21, 2022
  7. Elijah NewrenJan 22, 2022
  8. Ævar Arnfjörð BjarmasonJan 22, 2022
  9. Elijah NewrenJan 22, 2022
  10. Ævar Arnfjörð BjarmasonJan 24, 2022
  11. Jonathan TanJan 24, 2022
  12. Elijah NewrenJan 25, 2022
  13. Elijah NewrenJan 22, 2022
  14. Jonathan TanJan 24, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.