git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/3] git-p4: Rationalise command construction

From
Joel Holdsworth <jholdsworth@nvidia.com>
Date
Jan 6, 2022, 21:40 UTC
Message-ID
<20220106214035.90725-1-jholdsworth@nvidia.com>

This patch-set removes the mixing of commands constructed using strings with commands constructed using python lists. The goal being to simplify the code by standardising on the usage of lists throughout the script.

It also attempts to make usage of shell execution clearer by changing the code to require the caller to explicitly request execution-in-shell if required.

With the script changed over to using lists every, there is also a patch to improve the printing of log messages as command strings rather than as stringified python lists

This version of the patch-set adds a missing signoff, and corrects a typo in a commit message.

Joel Holdsworth (3):
  git-p4: don't select shell mode using the type of the command argument
  git-p4: pass command arguments as lists instead of using shell
  git-p4: don't print shell commands as python lists
 git-p4.py | 176 ++++++++++++++++++++++++------------------------------
 1 file changed, 79 insertions(+), 97 deletions(-)
-- 
2.34.1
Next: Joel Holdsworth
Message 1 of 4 in “git-p4: Rationalise command construction”
  1. 0/3 git-p4: Rationalise command constructionJoel Holdsworth, Jan 6, 2022
  2. 1/3 git-p4: don't select shell mode using the type of the command argumentJoel Holdsworth, Jan 6, 2022
  3. 2/3 git-p4: pass command arguments as lists instead of using shellJoel Holdsworth, Jan 6, 2022
  4. 3/3 git-p4: don't print shell commands as python listsJoel Holdsworth, Jan 6, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.