git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH RESEND] t/perf: do not run tests in user's $SHELL

From
Johannes Altmanninger <aclopte@gmail.com>
Date
Dec 25, 2021, 07:47 UTC
Message-ID
<20211225074736.ozxhbb67pzpaud6g@gmail.com>
In-Reply-To
<xmqqilvjugu0.fsf@gitster.g>
On Mon, Dec 20, 2021 at 01:06:15PM -0800, Junio C Hamano wrote:
Show 11 quoted lines
> Johannes Altmanninger <aclopte@gmail.com> writes:
> 
> > On Mon, Dec 20, 2021 at 12:56:58PM +0100, Ævar Arnfjörð Bjarmason wrote:
> >>     That was added later in 3f824e91c84 (t/Makefile:
> >>     introduce TEST_SHELL_PATH, 2017-12-08). We will always have that
> >>     available in perf-lib.sh since test-lib.sh will load it before this code
> >>     is executed.
> >
> > yes that's a good thing to point out
> 
> Care to redo the patch in a final form, then?

Of course. I should have acked that earlier, sorry. I waited until I could send my updated version but didn't find a quiet moment until today. Anyway, sending the updated patch now.

Previous: Junio C HamanoNext: Johannes Altmanninger
Message 5 of 6 in “t/perf: do not run tests in user's $SHELL”
  1. t/perf: do not run tests in user's $SHELLRené Scharfe, Dec 20, 2021
  2. Ævar Arnfjörð BjarmasonDec 20, 2021
  3. Johannes AltmanningerDec 20, 2021
  4. Junio C HamanoDec 20, 2021
  5. Johannes AltmanningerDec 25, 2021
  6. t/perf: do not run tests in user's $SHELLJohannes Altmanninger, Dec 25, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.