git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/5] git-p4: fix RCS keyword processing encoding errors

From
Joel Holdsworth <jholdsworth@nvidia.com>
Date
Dec 16, 2021, 13:46 UTC
Message-ID
<20211216134619.2048348-1-jholdsworth@nvidia.com>

This patch-set fixes a family of issues with git-p4's handling of incoming text data that contains RCS keywords, when those files contain bytes which are invalid UTF-8 codes.

Among the patches is a fix for the issue, as well as some peripheral tidy-ups and improvements to the existing code.

This patch-set is compatible and has been tested with both Python 2 and 3, and includes a test.

This v2 version of the patch-set seperates the read/write mode fix (4/5) out from the RCS byte processing patch (5/5)

Joel Holdsworth (5):
  git-p4: use with statements to close files after use in
    patchRCSKeywords
  git-p4: pre-compile RCS keyword regexes
  git-p4: add raw option to read_pipelines
  git-p4: open temporary patch file for write only
  git-p4: resolve RCS keywords in bytes not utf-8
 git-p4.py             | 66 ++++++++++++++++++-------------------------
 t/t9810-git-p4-rcs.sh | 15 ++++++++++
 2 files changed, 42 insertions(+), 39 deletions(-)
-- 
2.34.1
Next: Joel Holdsworth
Message 1 of 6 in “git-p4: fix RCS keyword processing encoding errors”
  1. 0/5 git-p4: fix RCS keyword processing encoding errorsJoel Holdsworth, Dec 16, 2021
  2. 1/5 git-p4: use with statements to close files after use in patchRCSKeywordsJoel Holdsworth, Dec 16, 2021
  3. 2/5 git-p4: pre-compile RCS keyword regexesJoel Holdsworth, Dec 16, 2021
  4. 3/5 git-p4: add raw option to read_pipelinesJoel Holdsworth, Dec 16, 2021
  5. 4/5 git-p4: open temporary patch file for write onlyJoel Holdsworth, Dec 16, 2021
  6. 5/5 git-p4: resolve RCS keywords in bytes not utf-8Joel Holdsworth, Dec 16, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.